Rollup of 13 pull requests #31633
Closed
Rollup of 13 pull requests #31633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
steveklabnik
commented
Feb 13, 2016
- Successful merges: Note rotate_{left,right} in wrapping_sh{lr} docs #31535, Fix documentation example in the book #31537, doc: concat_idents! macro: more on its limitations. #31542, mod.rs: fix typo #31559, Added a few words to indicate where the vector object is created. #31563, doc: add missing words #31582, doc: assert_eq on 2 boolean values is redundant #31584, doc: skipping (obvious) details here is worth making this more nice t… #31585, Remove unnecessary bounds on Error and Display implementations for TryLockError and PoisonError. #31589, Remove incorrect documentation #31607, Clarify what tx/rx mean in concurrency docs #31610, Remove unnecessary article #31612, Add a new i586 Linux target #31629
- Failed merges:
The code sections shouldn't be inside a ```text block.
Signed-off-by: NODA, Kai <nodakai@gmail.com>
"destructors" was misspelled.
…yLockError and PoisonError.
…ift-documentation, r=steveklabnik `wrapping_shl` and `wrapping_shr` are easy to mistake for rotations, when in fact they work somewhat differently. The documentation currently available is a little sparse and easy to misinterpret, so I've added a warning to anyone who bumps into them that the equivalent rotate methods may actually be what they're looking for. If it's deemed useful to add a symmetrical mention to the documentation for the `rotate_left` and `rotate_right` methods, I can certainly have a go at that, but my gut feeling is that people likely to want a rotate will already know about the wrapping-arithmetic methods, for example from writing CPU simulators.
…abnik The code sections shouldn't be inside a ```text block. r? @steveklabnik
…klabnik Just a small documentation change. It would be great if anyone could check my English.
…eveklabnik "destructors" was misspelled. r? @steveklabnik
This is a minor change. Please see title. IMO this is important since this is the first instance when we talk about allocating a vector. Not saying that it is allocated on the stack here leaves room for speculation and this might put off some people (they might not even read the later sections which go into more detail about this).
…ds, r=sfackler None
…veklabnik Not everyone knows this convention. We could just rename the variables in the example, but since this notation is commonly used it's a good opportunity to introduce it. r? @steveklabnik
I feel sorry for bothering you with such a literally one character changes. If it is counter productive feel free to point it out in the comments, that would be totally understandable. I could try to pack such a changes together in one PR to make them less distractive. r? @steveklabnik
This PR should make it easier to create a baseline x86 compiler as well as make cross-compilation possible through a separate set of rlibs. Plus, a few Linux distributions (e.g. Debian) have voiced interest in having this target available.
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ p=1000 |
|
📌 Commit 8895c45 has been approved by |
|
⌛ Testing commit 8895c45 with merge b7d46ee... |
|
💔 Test failed - auto-linux-64-nopt-t |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.