Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checking if there have been new errors. #31257

Merged
merged 1 commit into from Jan 28, 2016
Merged

Fix checking if there have been new errors. #31257

merged 1 commit into from Jan 28, 2016

Conversation

ghost
Copy link

@ghost ghost commented Jan 28, 2016

r? @nrc

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nrc (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@nikomatsakis
Copy link
Contributor

@bors r+ p=22

this is blocking compile-fail completely for me

@bors
Copy link
Contributor

bors commented Jan 28, 2016

📌 Commit b3e30b5 has been approved by nikomatsakis

@nikomatsakis
Copy link
Contributor

Also, score one for overflow checks! We really ought to be running these by default on homu in some configuration at least.

bors added a commit that referenced this pull request Jan 28, 2016
@bors
Copy link
Contributor

bors commented Jan 28, 2016

⌛ Testing commit b3e30b5 with merge 552bf75...

@bors bors merged commit b3e30b5 into rust-lang:master Jan 28, 2016
@ghost ghost deleted the track-errors-fix branch February 6, 2016 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants