-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable cross crate and unsafe const fn #30899
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
r? @pnkfelix (or someone else who's done const-fn-related-stuff) |
☔ The latest upstream changes (presumably #30975) made this pull request unmergeable. Please resolve the merge conflicts. |
c054c66
to
f2c0ecd
Compare
rebased |
ping @pnkfelix |
Also got rid of some code repetition in `const_eval`
Also got rid of some code repetition in
const_eval