-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Address issue of crates not being explained when introduced. #30836
Conversation
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
@bors: r+ rollup thank you! |
📌 Commit bda8e1e has been approved by |
@bors: r- actually, there's a weird commit in here that doesn't do anything, would you mind rebasing this first? |
@steveklabnik I also changed "it's" to "it is", which makes that sentence easier to read. If you do prefer, I'll rebase and remove it. Otherwise it seems to be a good change. I'd just forgotten to comment on it |
It's a good change! The merge commit is just the issue. |
Errr... Can you point me to some info please? I've pulled latest changes and merged, then rebased, but there doesn't appear to be any change. |
* ref: Issue #30825 Small punctuation change in "Crates and Modules".
wooot! thanks for sticking with this @bors: r+ rollup |
📌 Commit 52786de has been approved by |
Got it! I even learnt a few new tricks 😀 |
Ref issue [30825](rust-lang#30825) This commit should suffice to add a concise introduction to the concept of crates. My only worry, is that it is maybe too concise; but, the book seems to be written with the understanding that the new Rust user is coming from another language, and so will understand what a Library or Code Package is.
Ref issue 30825
This commit should suffice to add a concise introduction to the concept of crates.
My only worry, is that it is maybe too concise; but, the book seems to be written with the understanding that the new Rust user is coming from another language, and so will understand what a Library or Code Package is.