Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix article in Result.map and Result.map_err documentation #29787

Merged
merged 1 commit into from
Nov 12, 2015
Merged

Fix article in Result.map and Result.map_err documentation #29787

merged 1 commit into from
Nov 12, 2015

Conversation

dbrgn
Copy link
Contributor

@dbrgn dbrgn commented Nov 11, 2015

Fix usage of wrong article in Result docs.

This is my first rust PR, if something about the process is wrong let me know.

As this is a documentation change, I believe the correct highfive line to use is the following:

r? @steveklabnik

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@steveklabnik
Copy link
Member

Nope, this is perfect! Thanks so much!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Nov 11, 2015

📌 Commit 9b5b0cd has been approved by steveklabnik

Manishearth added a commit to Manishearth/rust that referenced this pull request Nov 12, 2015
Fix usage of wrong article in `Result` docs.

This is my first rust PR, if something about the process is wrong let me know.

As this is a documentation change, I believe the correct highfive line to use is the following:

r? @steveklabnik
bors added a commit that referenced this pull request Nov 12, 2015
@bors bors merged commit 9b5b0cd into rust-lang:master Nov 12, 2015
@dbrgn dbrgn deleted the docs-fix branch November 12, 2015 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants