Remove .ok().expect() #29613
Merged
Remove .ok().expect() #29613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in favor of just expect() Fixes rust-lang#29506
|
(rust_highfive has picked a reviewer for you, use r? to override) |
| we’re going to annotate its type. `u32` is an unsigned, thirty-two bit | ||
| integer. Rust has [a number of built-in number types][number], but we’ve | ||
| chosen `u32`. It’s a good default choice for a small positive number. | ||
| Here, `guess` refers to the old `guess`, the one that was a `String` with our |
There was a problem hiding this comment.
this is just removing the first sentence, and then reformatting
|
@bors: rollup |
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Nov 5, 2015
in favor of just expect() Fixes rust-lang#29506
bors
added a commit
that referenced
this pull request
Nov 5, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in favor of just expect()
Fixes #29506