rustfmt liblibc #29045
rustfmt liblibc #29045
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nrc (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Some of the empty function bodies should remain on one line. I filed https://github.com/nrc/rustfmt/issues/463. I don't think it needs fixing up. |
|
Could you remove the |
|
https://github.com/nrc/rustfmt/issues/465 From line 2962, I guess you could fix that up or leave it till we fix rustfmt. |
|
At line 5907 - https://github.com/nrc/rustfmt/issues/466 - this does need a fixup, I think. |
|
There's a few instances of that, actually. |
|
There's a lot of those, probably not worth trying to fixup manually, we should block on fixing https://github.com/nrc/rustfmt/issues/466 |
|
I thought that the functions alignments where meant to be like that after seeing few of them. I'll fix those and the misaligned SYNCHRONIZED and push the update soon. |
|
Ok. Then I won't touch it anymore and will wait for the fix. I will try to help but I don't know rust and rustfmt internals enough (yet) |
|
@mseri if you'd like to try and fix the rustfmt bug, it shouldn't be too hard (although not the easiest), I'm happy to mentor over on the rustfmt repo. You don't need to know anything about rust's internals. |
|
Thanks, I will look into it as soon as I get some free time. |
|
Is it possible to track down why rustfmt failed to reformat the long lines in commit d368102 ? |
|
@mseri it's because they are in an |
|
@nrc it is fixed indeed, with rustfmt commit |
|
It looks like now |
|
@mseri could you squash your commits please? It will give better history, but also I can't easily review this on GitHub. |
|
@nrc history cleaned |
|
📌 Commit 34a547f has been approved by |
r? @nrc Nothing special going on, the only real notable change is the explicit ABI on line 6183. I re-onlined some extern on top of the file by hand.
r? @nrc Nothing special going on, the only real notable change is the explicit ABI on line 6183. I re-onlined some extern on top of the file by hand.
r? @nrc
Nothing special going on, the only real notable change is the explicit ABI on line 6183.
I re-onlined some extern on top of the file by hand.