Rustfmt-ing liblog v2. #28991
Rustfmt-ing liblog v2. #28991
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| LogDirective { name: Some("crate1::mod1".to_string()), level: 0 } | ||
| ]; | ||
| let dirs = [LogDirective { | ||
| name: None, |
There was a problem hiding this comment.
This seems wrong, it should be indented relative to beginning of LogDirective (above and below too).
|
I'd like to see if https://github.com/nrc/rustfmt/pull/449 fixes the odd formatting in the tests. The only other thing is the comment which needs fixing up, otherwise looks good! |
c015a35 to
5943af3
Compare
|
@nrc, @alexcrichton I've run latest rustfmt and semmed to fix the issues. Also manually aligned comments. |
|
I'm inclined to r+, but I'll wait on what @alexcrichton thinks. |
|
LGTM @goyox86 thanks for the changes! |
|
Sweet! @nrc The CI bot will merge it. Or do I have to merge? |
|
📌 Commit 94946db has been approved by |
…I, r=alexcrichton Hi Rustaceans! This is the second version of running rustfmt on liblog rust-lang#28898. There are only rustfmt suggested changes. Because I think that some patterns here (that I fixed up in the prev PR need to be discussed in detail. //cc @nrc
Hi Rustaceans!
This is the second version of running rustfmt on liblog #28898. There are only rustfmt suggested changes. Because I think that some patterns here (that I fixed up in the prev PR need to be discussed in detail.
//cc @nrc