Un-regress conflicting destructors #28681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of type inference, duplicate obligations exist and cause duplicate errors. To avoid this, only display the first error for each (predicate,span). The inclusion of the span is somewhat bikesheddy, but *is* the more conservative option (it does not remove some instability, as duplicate obligations are ignored by `duplicate_set` under some inference conditions). Fixes rust-lang#28098 cc rust-lang#21528 (is it a dupe?)
different supertraits can suffer from the same object-safety violation, leading to duplication in the error message. Avoid it. Fixes rust-lang#20692
|
@bors r+ |
|
📌 Commit 9a86713 has been approved by |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Sep 27, 2015
|
The linked issue indicates this regression is on beta. Backport? cc @rust-lang/compiler |
|
@rust-lang/compiler I have no opinion about backporting this to beta; I certainly don't object, but I also don't think its the end of the world if an ICE remains. (That's assuming one always hits an ICE ... if someone were to demonstrate an example where the program has two destructors and the compiler erroneously accepts it, then that would change my opinion to be strongly in favor of a backport.) |
|
I would not ordinarily be in favor of backporting, but if it's a regression I think we ought to. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28568
r? @eddyb