Specify linkers for cross-compile scenarios #25719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent MSVC patch made the build system pass explicit linkers to rustc, but did not set that up for anything other than MSVC.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
This only modified the platforms that we need for the bots but presumably all other cross-compiles are broken too. |
|
Maybe a better solution would be to fall back to the old behavior of the linker hasn't been overridden. |
|
@bors r+ |
|
📌 Commit 1cda323 has been approved by |
|
Thanks @eddyb |
bors
added a commit
that referenced
this pull request
May 24, 2015
The recent MSVC patch made the build system pass explicit linkers to rustc, but did not set that up for anything other than MSVC. This is blocking nightlies.
|
For anyone else reading this and looking for the MSVC PR, it's #25350 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent MSVC patch made the build system pass explicit linkers to
rustc, but did not set that up for anything other than MSVC.
This is blocking nightlies.