Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Fix print value #25150

Closed
wants to merge 1 commit into from
Closed

doc: Fix print value #25150

wants to merge 1 commit into from

Conversation

rydotyosh
Copy link
Contributor

input -> guess

`input` -> `guess`
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @huonw (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@killercup
Copy link
Member

Too late? #25148

@rydotyosh
Copy link
Contributor Author

Oh, tanks. It is same.
And then, the return value input is never used.

@killercup
Copy link
Member

Indeed, that unused value is not cool.

@steveklabnik, maybe you want to r+ this instead of #25148?

@steveklabnik
Copy link
Member

Oh, nice catch!

So that everyone gets credit, @rydotyosh, what do you think about editing this PR to just include the return fix?

@rydotyosh
Copy link
Contributor Author

OK.

@rydotyosh rydotyosh closed this May 6, 2015
steveklabnik added a commit to steveklabnik/rust that referenced this pull request May 7, 2015
steveklabnik added a commit to steveklabnik/rust that referenced this pull request May 7, 2015
@rydotyosh rydotyosh deleted the patch-2 branch May 7, 2015 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants