Remove some deprecated items #25132
Closed
Remove some deprecated items #25132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -69,9 +69,11 @@ impl FileAttr { | |||
| FilePermissions { mode: (self.stat.st_mode as mode_t) & 0o777 } | |||
| } | |||
|
|
|||
| #[allow(dead_code)] | |||
There was a problem hiding this comment.
(I figure these will come in handy in the future)
|
Thanks for this! At this point though we're not removing any deprecated stable functionality (we've already cleaned out what was intended to go), but in general removing deprecated unstable items is fine. I'd leave the deprecated unicode stuff for now as it moved out somewhat recently, however. |
These have been deprecated for some time. This is a: [breaking-change]
|
☔ The latest upstream changes (presumably #25136) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Now that 1.0 has been released I believe that this is now a breaking change, so closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These have been deprecated for some time. This is a:
[breaking-change]