Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support for aarch64-linux-android #21414

Merged
merged 1 commit into from
Jan 22, 2015

Conversation

ejjeong
Copy link
Contributor

@ejjeong ejjeong commented Jan 20, 2015

Initial support for aarch64-linux-android (#18920)

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pcwalton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@ejjeong
Copy link
Contributor Author

ejjeong commented Jan 20, 2015

cc @yichoi

@ejjeong ejjeong force-pushed the aarch64-linux-android branch from 016bb0b to 9400805 Compare January 20, 2015 08:45
@alexcrichton
Copy link
Member

@bors: r+ 9400805

@@ -357,6 +358,7 @@ impl Target {
i386_apple_ios,
x86_64_apple_ios,
aarch64_apple_ios,
aarch64_linux_android,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pure cosmetics: can this line be moved to linux group or may be extract all android targets in it is own group

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sure. Thanks for finding this.
But since this commit is already being tested by bors, I'll fix it in my next PR.

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Jan 21, 2015
Initial support for aarch64-linux-android (rust-lang#18920)
- Add new configuration files
- Modify some options to compile & link succesfully.
  (PIE, disable tls on jemalloc, modify some external function linkage, ..)
- To build, refer to https://github.com/rust-lang/rust/wiki/Doc-building-for-android.
   (tested with platform=21 and toolchain=aarch64-linux-android-4.9)
@bors bors merged commit 9400805 into rust-lang:master Jan 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants