Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emacs: Mark _ as a word constituent to avoid highlighting parts of identifiers as keywords #20894

Merged
merged 1 commit into from
Jan 12, 2015

Conversation

swgillespie
Copy link
Contributor

rust-mode.el recently started highlighting keywords that were substrings of identifiers. Identifiers such as xyz_type would have type highlighted, which isn't normal. This patch re-introduces _ as a word constituent, so that keywords following a _ don't get syntax highlighted as keywords. Fixes issue #20422

@rust-highfive
Copy link
Collaborator

r? @pcwalton

(rust_highfive has picked a reviewer for you, use r? to override)

@swgillespie swgillespie changed the title emacs: Mark _ as a word constituent to avoid highlighting parts of identifiers as key emacs: Mark _ as a word constituent to avoid highlighting parts of identifiers as keywords Jan 10, 2015
@huonw
Copy link
Member

huonw commented Jan 11, 2015

r? @pnkfelix

bors added a commit that referenced this pull request Jan 12, 2015
rust-mode.el recently started highlighting keywords that were substrings of identifiers. Identifiers such as `xyz_type` would have `type` highlighted, which isn't normal. This patch re-introduces `_` as a word constituent, so that keywords following a `_` don't get syntax highlighted as keywords. Fixes issue #20422
@bors bors merged commit f82c75b into rust-lang:master Jan 12, 2015
@swgillespie swgillespie deleted the emacs-issue-20422 branch January 12, 2015 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants