Add capacity() to VecMap #19528
Merged
Add capacity() to VecMap #19528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// assert_eq!(map.capacity(), 10); | ||
| /// ``` | ||
| #[inline] | ||
| #[stable] |
There was a problem hiding this comment.
We're currently marking these with #[unstable = "matches collection reform specification, waiting for dust to settle"]
|
Thanks for persevering on this! I hope to have the RFC ready next week. I will CC you on it. |
|
Thanks! I was slightly worried I would be annoying you with all the PRs, but this is my first set of PRs ever, and I wanted to establish myself as a contributor :P |
|
Everything looks good, can you squash the commits into one for a clean history? |
Changed capacity() tag to unstable and fixed doc assert
4616436 to
0d3c415
Compare
|
Okay, squashed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #18424
Adds
capacity()function to VecMap, as per the collections reform.(Salvaged from #19516, #19523, while we await an RFC regarding
reserve/reserve_indexforVecMap)