Add support for looking up a name introduced by an 'use' #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops! When I said "use_or_import sounds ok" I really thought I just meant for the one function, parse_use_or_import. In rustboot we call the import/export section of a module its "view". Maybe you can s/use_or_export/view/ on all this? Otherwise looks good. |
parsing regular items.
With this we go from "error: unresolved name: foo" to
"unimplemented definition variant for: foo" in
use foo;
fn main(vec[str] args) {
foo.bar();
}
|
ah, it is so much better to have a name for things :-) |
keeperofdakeys
pushed a commit
to keeperofdakeys/rust
that referenced
this pull request
Dec 12, 2017
Audit the LFS functions from Linux and add the same for Android if bionic supports it, according to libc.map from API 23 (Android 6.0). The standard library is currently limited to API 18, so it may only use `lseek64`, `pread64`, `pwrite64`, `ftruncate64`, and `readahead`. Note that `stat64` and `dirent64` are actually identical to the regular versions, because bionic has always mapped them to the LFS syscalls. It also sets `O_LARGEFILE` at all times, so `open` matches `open64`. Still, the explicit LFS names may be useful to match Linux. Fixes rust-lang#189.
kazcw
pushed a commit
to kazcw/rust
that referenced
this pull request
Oct 23, 2018
djtech-dev
pushed a commit
to djtech-dev/rust
that referenced
this pull request
Dec 9, 2021
Update `inkwell_internals` to 0.2
matthiaskrgr
pushed a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 7, 2023
…tests Disable UI tests that fail on the rustc side
celinval
pushed a commit
to celinval/rust-dev
that referenced
this pull request
Nov 29, 2024
Towards rust-lang#150 ### Changes * Added harnesses for `to_bytes` and `to_bytes_with_nul` * Added a small fix to `count_bytes` Verification Result: ``` Checking harness ffi::c_str::verify::check_to_bytes_with_nul... VERIFICATION RESULT: ** 0 of 179 failed (5 unreachable) VERIFICATION:- SUCCESSFUL Verification Time: 88.397385s Checking harness ffi::c_str::verify::check_to_bytes... VERIFICATION RESULT: ** 0 of 180 failed (5 unreachable) VERIFICATION:- SUCCESSFUL Verification Time: 79.66312s Checking harness ffi::c_str::verify::check_from_bytes_until_nul... VERIFICATION RESULT: ** 0 of 132 failed (5 unreachable) VERIFICATION:- SUCCESSFUL Verification Time: 28.593569s Complete - 3 successfully verified harnesses, 0 failures, 3 total. ```
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main question in these patches is if we should add a def_use or use the existing def_mod. Since we intend to lazily read a crate, we agreed on IRC that it was better to add a def_use.