libsyntax: Explicit error message for sugared doc comments. #17218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3343,22 +3343,32 @@ impl<'a> Parser<'a> { | |||
| }) | |||
| } | |||
|
|
|||
| /// Get an expected item after attributes error message. | |||
| fn expected_item_err(attrs: &[Attribute]) -> &'static str { | |||
| if attrs.iter().any(|attr| attr.node.is_sugared_doc) { | |||
There was a problem hiding this comment.
I think this should just check the last one, or possibly list all possibilities.
e.g, talking about doc comments for
/// Foo
#[inline]
#[foo]
#[bar]is a little weird.
There was a problem hiding this comment.
Good idea. I will submit an update tomorrow at some point.
0a8f097 to
7005ab0
Compare
Display an explicit message about items missing after sugared doc comment attributes. References rust-lang#2789.
7005ab0 to
4a76700
Compare
|
r? Rebased and looking to get some movement. |
|
Thanks! |
bors
added a commit
that referenced
this pull request
Sep 20, 2014
…huonw Display an explicit message about items missing after sugared doc comment attributes. References #2789. * I tried looking through `parser.rs` for an appropriate location for `expected_item_err` and ended up putting it just above the first use. Is there a better location? * Did I add enough test cases? Too many? Should I add more cases for the original error message?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display an explicit message about items missing after sugared doc
comment attributes. References #2789.
parser.rsfor an appropriate location forexpected_item_errand ended up putting it just above the first use. Is there a better location?