Implement cell::clone_ref #14189
Closed
Implement cell::clone_ref #14189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -186,6 +186,24 @@ impl<'b, T> Deref<T> for Ref<'b, T> { | |||
| } | |||
| } | |||
|
|
|||
| /// Copy a `Ref`. The `RefCell` is already immutably borrowed, | |||
| /// so this cannot fail. | |||
There was a problem hiding this comment.
Prevailing convention is one space after the period.
Also, did you intend for the second sentence to be part of the method summary? I would expect that to be in the description.
Per discussion with @alexcrichton, this is a free function.
| /// A `Clone` implementation would interfere with the widespread | ||
| /// use of `r.borrow().clone()` to clone the contents of a `RefCell`. | ||
| #[experimental] | ||
| pub fn clone_ref<'b, T>(orig: &Ref<'b, T>) -> Ref<'b, T> { |
There was a problem hiding this comment.
I assume this doesn't just call orig.parent.borrow() to avoid code bloat from fail!?
There was a problem hiding this comment.
And to avoid checking if the borrow flag is set to WRITING. LLVM can optimize
let y = x.get();
x.set(y + 1);
into a single inc instruction.
|
Yay for free functions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion with @alexcrichton, this is a free function.