Add debug_assert and debug_assert_eq macros #13789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you grep for |
|
Updated |
|
Are we testing things with both |
|
If not, we should just turn on |
|
|
I also switched some `assert!` calls over to `debug_assert!`. Closes rust-lang#12049. RFC: 0015-assert
|
This should be good to go. cc @pcwalton |
bors
added a commit
that referenced
this pull request
May 2, 2014
I switched the `assert!` calls in `RefCell` over to `debug_assert!`. There are probably other instances that should be converted as well, but I couldn't think of any off the top of my head. RFC: 0015-assert
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 20, 2023
feat: show only missing variant suggestion for enums in patterns completion and bump them in list too Fixes rust-lang#12438 ### Points to help in review: - This PR can be reviewed commit wise, first commit is about bumping enum variant completions up in the list of completions and second commit is about only showing enum variants which are not complete - I am calculating missing variants in analysis.rs by firstly locating the enum and then comparing each of it's variant's name and checking if arm string already contains that name, this is kinda hacky but I didn't want to implement complete missing_arms assist here as that would have been too bulky to run on each completion cycle ( if we can improve this somehow would appreciate some inputs on it ) ### Output: https://user-images.githubusercontent.com/49019259/208245540-57d7321b-b275-477e-bef0-b3a1ff8b7040.mov Relevant Zulip Discussion: https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Frust-analyzer/topic/Issue.20.2312438
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Dec 15, 2024
This addresses rust-lang#13099 for the manual_split_once test, using the str_splitn lint. changelog: [str_splitn]: Updated str_splitn to use multipart_suggestions where appropriate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I switched the
assert!calls inRefCellover todebug_assert!.There are probably other instances that should be converted as well, but
I couldn't think of any off the top of my head.
RFC: 0015-assert