Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use stage 2 on cargo and clippy tests when possible #137522

Merged
merged 3 commits into from
Feb 25, 2025
Merged

use stage 2 on cargo and clippy tests when possible #137522

merged 3 commits into from
Feb 25, 2025

Conversation

onur-ozkan
Copy link
Member

Follow-up for #137215.

For more context, read the discussion starting from #137215 (comment).

r? Kobzol (Feel free to re-r if you are not available).

@onur-ozkan
add explicit stage fields to Config
37b18f8 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan
add coverage for explicit stage fields
cf6dc74 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Feb 24, 2025
@rustbot
Copy link
Collaborator

rustbot commented Feb 24, 2025

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

Kobzol
Kobzol reviewed Feb 24, 2025
View reviewed changes
Copy link
Contributor

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Left two nits, but both are non-blocking, so feel free to r=me even without them.

@onur-ozkan
Copy link
Member Author

Both notes makes sense, will address them later today.

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 24, 2025
@onur-ozkan
use stage 2 on cargo and clippy tests when possible
9ad6011 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan
Copy link
Member Author

@bors ready

@Kobzol
Copy link
Contributor

Kobzol commented Feb 24, 2025

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Feb 24, 2025

📌 Commit 9ad6011 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 24, 2025
fmease added a commit to fmease/rust that referenced this pull request Feb 25, 2025
@fmease
Rollup merge of rust-lang#137522 - onur-ozkan:137215-follow-ups, r=Ko…
8e4d6e7 
…bzol

use stage 2 on cargo and clippy tests when possible

Follow-up for rust-lang#137215.

For more context, read the discussion starting from rust-lang#137215 (comment).

r? Kobzol (Feel free to re-r if you are not available).
This was referenced Feb 25, 2025
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 25, 2025
@bors
Auto merge of rust-lang#137611 - fmease:rollup-ln673ux, r=fmease
4ecd70d 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#135480 (Don't require method impls for methods with `Self:Sized` bounds for impls for unsized types)
 - rust-lang#137360 (Use `as_chunks` in `analyze_source_file_sse2`)
 - rust-lang#137460 (downgrade bootstrap `cc`)
 - rust-lang#137515 (Update `compiler-builtins` to 0.1.148)
 - rust-lang#137522 (use stage 2 on cargo and clippy tests when possible)
 - rust-lang#137597 (Revert accidental cargo submodule update)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e6bd9e6 into rust-lang:master Feb 25, 2025
6 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Feb 25, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 25, 2025
@rust-timer
Unrolled build for rust-lang#137522
b899204 
Rollup merge of rust-lang#137522 - onur-ozkan:137215-follow-ups, r=Kobzol

use stage 2 on cargo and clippy tests when possible

Follow-up for rust-lang#137215.

For more context, read the discussion starting from rust-lang#137215 (comment).

r? Kobzol (Feel free to re-r if you are not available).
@onur-ozkan onur-ozkan deleted the 137215-follow-ups branch February 25, 2025 21:59
@onur-ozkan onur-ozkan mentioned this pull request Feb 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kobzol Kobzol Kobzol left review comments

Assignees

@Kobzol Kobzol

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.87.0
Development

Successfully merging this pull request may close these issues.
4 participants
@onur-ozkan @rustbot @Kobzol @bors