Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cargo #137057

Merged
merged 1 commit into from
Feb 15, 2025
Merged

Update cargo #137057

merged 1 commit into from
Feb 15, 2025

Conversation

weihanglo
Copy link
Member

@weihanglo weihanglo commented Feb 15, 2025

13 commits in 2928e32734b04925ee51e1ae88bea9a83d2fd451..ce948f4616e3d4277e30c75c8bb01e094910df39
2025-02-07 16:50:22 +0000 to 2025-02-14 20:32:07 +0000

Also add Zlib to Cargo's license exception
@weihanglo weihanglo self-assigned this Feb 15, 2025
@rustbot
Copy link
Collaborator

rustbot commented Feb 15, 2025

⚠️ Warning ⚠️

  • These commits modify submodules.

@rustbot
Copy link
Collaborator

rustbot commented Feb 15, 2025

Some changes occurred in src/tools/cargo

cc @ehuss

The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging.

cc @davidtwco, @wesleywiser

@rustbot rustbot added A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Feb 15, 2025
@weihanglo
Copy link
Member Author

This PR also adds Zlib to Cargo's license exceptions. It is already an exception of other components so should be fine.

@bors r+ rollup=never p=1

@bors
Copy link
Contributor

bors commented Feb 15, 2025

📌 Commit ed870c3 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 15, 2025
@bors
Copy link
Contributor

bors commented Feb 15, 2025

⌛ Testing commit ed870c3 with merge 9cd60bd...

@bors
Copy link
Contributor

bors commented Feb 15, 2025

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 9cd60bd to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 15, 2025
@bors bors merged commit 9cd60bd into rust-lang:master Feb 15, 2025
7 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Feb 15, 2025
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (9cd60bd): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary -2.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.4% [-2.4%, -2.4%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 789.44s -> 789.619s (0.02%)
Artifact size: 347.24 MiB -> 350.04 MiB (0.81%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tidy Area: The tidy tool merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants