Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sccache in CI to 0.9.1 #137023

Merged
merged 4 commits into from
Feb 20, 2025
Merged

Bump sccache in CI to 0.9.1 #137023

merged 4 commits into from
Feb 20, 2025

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Feb 14, 2025

We haven't updated the used sccache version for years, it has accrued a bunch of fixes and features in the meantime. It now supports the --show-adv-stats flag, which gives a more detailed summary of the results of caching. And it can also cache Rust code, which could be useful in the future (#136942 - although now there are no large wins).

It also supports caching PGO now, but since the PGO profiles are always different, it won't make any real difference.

#133076 previously tried to update the version to 0.3 (CC @klensy)

r? @marcoieni

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Feb 14, 2025
@Kobzol
Copy link
Contributor Author

Kobzol commented Feb 14, 2025

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 14, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 14, 2025
Bump sccache in CI to 0.9.1

We haven't updated the used sccache version for years, it has accrued a bunch of fixes and features in the meantime. It now supports the `--show-adv-stats` flag, which gives a more detailed summary of the results of caching. And it can also cache Rust code, which could be useful in the future (rust-lang#136942 - although now there are no large wins).

It also supports caching PGO now, but since the PGO profiles are always different, it won't make any real difference.

rust-lang#133076 previously tried to update the version to 0.3 (CC `@klensy)`

r? `@marcoieni`
@bors
Copy link
Contributor

bors commented Feb 14, 2025

⌛ Trying commit 0d0a2a3 with merge 37b4ba8...

@klensy
Copy link
Contributor

klensy commented Feb 14, 2025

In my attempts to update sccache, i remember that it reported successful cached calls for jobs, where it didn't actually used (for llvm caching), i found it weird.

So someone was using, but idk who.

@bors
Copy link
Contributor

bors commented Feb 14, 2025

☀️ Try build successful - checks-actions
Build commit: 37b4ba8 (37b4ba88136d3da74d8cfd30fbabc8fef82f07f3)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (37b4ba8): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 787.772s -> 790.42s (0.34%)
Artifact size: 348.36 MiB -> 348.35 MiB (-0.00%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 14, 2025
@marcoieni
Copy link
Member

LGTM. Feel free to r=me 👍

@Kobzol
Copy link
Contributor Author

Kobzol commented Feb 14, 2025

@bors r=marcoieni rollup=never

@bors
Copy link
Contributor

bors commented Feb 14, 2025

📌 Commit 0d0a2a3 has been approved by marcoieni

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 14, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 19, 2025
Bump sccache in CI to 0.9.1

We haven't updated the used sccache version for years, it has accrued a bunch of fixes and features in the meantime. It now supports the `--show-adv-stats` flag, which gives a more detailed summary of the results of caching. And it can also cache Rust code, which could be useful in the future (rust-lang#136942 - although now there are no large wins).

It also supports caching PGO now, but since the PGO profiles are always different, it won't make any real difference.

rust-lang#133076 previously tried to update the version to 0.3 (CC `@klensy)`

r? `@marcoieni`
@bors
Copy link
Contributor

bors commented Feb 19, 2025

⌛ Testing commit 0d0a2a3 with merge 1f88568...

@bors
Copy link
Contributor

bors commented Feb 19, 2025

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 19, 2025
@rust-log-analyzer
Copy link
Collaborator

The job dist-powerpc64le-linux failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@Kobzol
Copy link
Contributor Author

Kobzol commented Feb 19, 2025

This essentially wiped the sccache cache, and this builder didn't like it, lol. Let's try again with the cache (hopefully) primed.

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 19, 2025
@bors
Copy link
Contributor

bors commented Feb 20, 2025

⌛ Testing commit 0d0a2a3 with merge eeb9035...

@bors
Copy link
Contributor

bors commented Feb 20, 2025

☀️ Test successful - checks-actions
Approved by: marcoieni
Pushing eeb9035 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 20, 2025
@bors bors merged commit eeb9035 into rust-lang:master Feb 20, 2025
7 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Feb 20, 2025
@Kobzol Kobzol deleted the bump-sccache branch February 20, 2025 09:43
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (eeb9035): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 2.2%, secondary 3.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.2% [1.6%, 2.8%] 2
Regressions ❌
(secondary)
3.3% [3.3%, 3.3%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.2% [1.6%, 2.8%] 2

Cycles

Results (primary -3.7%, secondary 2.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.9% [2.9%, 2.9%] 1
Improvements ✅
(primary)
-3.7% [-6.5%, -1.3%] 8
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -3.7% [-6.5%, -1.3%] 8

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 772.927s -> 772.938s (0.00%)
Artifact size: 360.27 MiB -> 360.27 MiB (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants