Rollup of 12 pull requests #136809
Merged
Rollup of 12 pull requests #136809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…--stage-id` Notably, this avoids having to do hacky string splitting based on `--stage-id`.
Even though the coverage graph itself is no longer available during codegen, its nodes can still be used as opaque IDs.
`Instant::now()` works correctly on Emscripten since rust-lang/libc#3962. All wasm-family targets with OS support can now handle instants.
They use 2 spaces by default, not 4.
coverage: Defer part of counter-creation until codegen Follow-up to rust-lang#135481 and rust-lang#135873. One of the pleasant properties of the new counter-assignment algorithm is that we can stop partway through the process, store the intermediate state in MIR, and then resume the rest of the algorithm during codegen. This lets it take into account which parts of the control-flow graph were eliminated by MIR opts, resulting in fewer physical counters and simpler counter expressions. Those improvements end up completely obsoleting much larger chunks of code that were previously responsible for cleaning up the coverage metadata after MIR opts, while also doing a more thorough cleanup job. (That change also unlocks some further simplifications that I've kept out of this PR to limit its scope.)
…alt, r=Mark-Simulacrum Removed dependency on the field-offset crate, alternate approach This is an alternate approach to reach the same goals as rust-lang#136003. As it touches the core of the query system, this too probably should be evaluated for performance. r? ``@Mark-Simulacrum``
Simplify Rc::as_ptr docs + typo fix
…, r=Mark-Simulacrum fix(libtest): Enable Instant on Emscripten targets `Instant::now()` works correctly on Emscripten since rust-lang/libc#3962. All wasm-family targets with OS support can now handle instants. Improves rust-lang#131738. ~~This changes the behavior of libtest on `unknown-unknown`/`unknown-none` wasm targets, but as far as I can see, libtest doesn't support them anyway. (Can anyone double-check?)~~ UPD: this patch no longer affects `unknown-unknown` targets. ``@rustbot`` label +A-libtest +T-testing-devex +O-emscripten +O-wasm -needs-triage
…crum [`compiletest`-related cleanups 2/7] Feed stage number to compiletest directly Reference for overall changes: rust-lang#136437 Part **2** of **7** of the *`compiletest`-related cleanups* PR series. ### Summary - Pass stage number via new `--stage` compiletest flag directly from bootstrap, instead of deriving that info in compiletest by doing gymnastics on `--stage-id`. - Just a cleanup, should have no functional changes. r? bootstrap
… r=Mark-Simulacrum ci: stop mysql before removing it try-job: aarch64-gnu
…Mark-Simulacrum Use an `Option` for `FindNextFileHandle` in `ReadDir` instead of `INVALID_FILE_HANDLE` sentinel value Sometimes we store an invalid handle when we don't want to return an error. We then check the handle before use in order to avoid actually using the invalid handle. However, using an `Option` for this is better and avoids us forgetting to check the handle is valid. This was noticed due to us closing the handle without checking for validity: https://github.com/rust-lang/rust/blob/bd6a6777f5cbbec549f123995026cef76d1e6b84/library/std/src/sys/pal/windows/fs.rs#L148-L151
…=jhpratt Some miscellaneous edition-related library tweaks Some library edition tweaks that can be done separately from upgrading the whole standard library to edition 2024 (which is blocked on getting the submodules upgraded, for example)
Bump `cc` to v1.2.13 for the compiler workspace
…=compiler-errors Git blame ignore recent formatting commit This ignores the commit 1fcae03 from rust-lang#136751 that applied updating formatting changes.
Don't apply editorconfig to llvm They use 2 spaces by default, not 4.
|
@bors r+ rollup=never p=5 |
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: 80c091958f In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Feb 10, 2025
Open
|
Finished benchmarking commit (8c04e39): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary 3.0%, secondary 3.0%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 782.79s -> 779.051s (-0.48%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
compiletest-related cleanups 2/7] Feed stage number to compiletest directly #136472 ([compiletest-related cleanups 2/7] Feed stage number to compiletest directly)OptionforFindNextFileHandleinReadDirinstead ofINVALID_FILE_HANDLEsentinel value #136552 (Use anOptionforFindNextFileHandleinReadDirinstead ofINVALID_FILE_HANDLEsentinel value)ccto v1.2.13 for the compiler workspace #136707 (Bumpccto v1.2.13 for the compiler workspace)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup