Put the alloc unit tests in a separate alloctests package #136642

bjorn3 · 2025-02-06T12:50:37Z

Same rationale as #135937. This PR has some extra complexity though as a decent amount of tests are testing internal implementation details rather than the public api. As such I opted to include the modules containing the types under test using #[path] into the alloctests package. This means that those modules still need #[cfg(test)], but the rest of liballoc no longer need it.

rustbot · 2025-02-06T12:50:46Z

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2025-02-06T12:50:48Z

These commits modify the library/Cargo.lock file. Unintentional changes to library/Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

bors · 2025-02-07T21:44:37Z

☔ The latest upstream changes (presumably #136697) made this pull request unmergeable. Please resolve the merge conflicts.

library/alloctests/lib.rs

cuviper · 2025-02-13T20:02:51Z

@bors r+

bors · 2025-02-13T20:02:54Z

📌 Commit 1726670 has been approved by cuviper

It is now in the queue for this repository.

…=cuviper Put the alloc unit tests in a separate alloctests package Same rationale as rust-lang#135937. This PR has some extra complexity though as a decent amount of tests are testing internal implementation details rather than the public api. As such I opted to include the modules containing the types under test using `#[path]` into the alloctests package. This means that those modules still need `#[cfg(test)]`, but the rest of liballoc no longer need it.

…kingjubilee Rollup of 13 pull requests Successful merges: - rust-lang#135439 (Make `-O` mean `OptLevel::Aggressive`) - rust-lang#136460 (Simplify `rustc_span` `analyze_source_file`) - rust-lang#136642 (Put the alloc unit tests in a separate alloctests package) - rust-lang#136904 (add `IntoBounds` trait) - rust-lang#136908 ([AIX] expect `EINVAL` for `pthread_mutex_destroy`) - rust-lang#136924 (Add profiling of bootstrap commands using Chrome events) - rust-lang#136951 (Use the right binder for rebinding `PolyTraitRef`) - rust-lang#136956 (add vendor directory to .gitignore) - rust-lang#136967 (Use `slice::fill` in `io::Repeat` implementation) - rust-lang#136976 (alloc boxed: docs: use MaybeUninit::write instead of as_mut_ptr) - rust-lang#136981 (ci: switch loongarch jobs to free runners) - rust-lang#136992 (Update backtrace) - rust-lang#136993 ([cg_llvm] Remove dead error message) r? `@ghost` `@rustbot` modify labels: rollup

workingjubilee · 2025-02-14T05:34:48Z

Testing for #136998 (comment)
@bors r-
@bors try

cuviper · 2025-03-06T22:15:56Z

@bors r+

bors · 2025-03-06T22:15:59Z

📌 Commit bf6ede0 has been approved by cuviper

It is now in the queue for this repository.

bors · 2025-03-07T17:34:23Z

☔ The latest upstream changes (presumably #138155) made this pull request unmergeable. Please resolve the merge conflicts.

For the tests that make use of internal implementation details, we include the module to test using #[path] in alloctests now.

bjorn3 · 2025-03-07T19:12:13Z

Rebased

@bors r=cuviper

bors · 2025-03-07T19:12:18Z

📌 Commit 22d0440 has been approved by cuviper

It is now in the queue for this repository.

…=cuviper Put the alloc unit tests in a separate alloctests package Same rationale as rust-lang#135937. This PR has some extra complexity though as a decent amount of tests are testing internal implementation details rather than the public api. As such I opted to include the modules containing the types under test using `#[path]` into the alloctests package. This means that those modules still need `#[cfg(test)]`, but the rest of liballoc no longer need it.

…mpiler-errors Rollup of 10 pull requests Successful merges: - rust-lang#135651 (Support for `wasm32-wali-linux-musl` Tier-3 target) - rust-lang#136642 (Put the alloc unit tests in a separate alloctests package) - rust-lang#137337 (Add verbatim linker to AIXLinker) - rust-lang#137549 (Clean up various LLVM FFI things in codegen_llvm) - rust-lang#137957 (Remove i586-pc-windows-msvc) - rust-lang#138063 (Improve `-Zunpretty=hir` for parsed attrs) - rust-lang#138137 (setTargetTriple now accepts Triple rather than string) - rust-lang#138141 (tests: fix some typos in comment) - rust-lang#138150 (Streamline HIR intravisit `visit_id` calls for items) - rust-lang#138173 (Delay bug for negative auto trait rather than ICEing) r? `@ghost` `@rustbot` modify labels: rollup

…=cuviper Put the alloc unit tests in a separate alloctests package Same rationale as rust-lang#135937. This PR has some extra complexity though as a decent amount of tests are testing internal implementation details rather than the public api. As such I opted to include the modules containing the types under test using `#[path]` into the alloctests package. This means that those modules still need `#[cfg(test)]`, but the rest of liballoc no longer need it.

…mpiler-errors Rollup of 8 pull requests Successful merges: - rust-lang#136642 (Put the alloc unit tests in a separate alloctests package) - rust-lang#137337 (Add verbatim linker to AIXLinker) - rust-lang#137363 (compiler: factor Windows x86-32 ABI impl into its own file) - rust-lang#137685 (self-contained linker: conservatively default to `-znostart-stop-gc` on x64 linux) - rust-lang#138000 (atomic: clarify that failing conditional RMW operations are not 'writes') - rust-lang#138063 (Improve `-Zunpretty=hir` for parsed attrs) - rust-lang#138137 (setTargetTriple now accepts Triple rather than string) - rust-lang#138173 (Delay bug for negative auto trait rather than ICEing) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 5 pull requests Successful merges: - rust-lang#136642 (Put the alloc unit tests in a separate alloctests package) - rust-lang#137528 (Windows: Fix error in `fs::rename` on Windows 1607) - rust-lang#137685 (self-contained linker: conservatively default to `-znostart-stop-gc` on x64 linux) - rust-lang#137757 (On long spans, trim the middle of them to make them fit in the terminal width) - rust-lang#138189 (Mention `env` and `option_env` macros in `std::env::var` docs) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#136642 - bjorn3:separate_alloctest_crate, r=cuviper Put the alloc unit tests in a separate alloctests package Same rationale as rust-lang#135937. This PR has some extra complexity though as a decent amount of tests are testing internal implementation details rather than the public api. As such I opted to include the modules containing the types under test using `#[path]` into the alloctests package. This means that those modules still need `#[cfg(test)]`, but the rest of liballoc no longer need it.

rustbot assigned cuviper Feb 6, 2025

This comment has been minimized.

Sign in to view

bjorn3 force-pushed the separate_alloctest_crate branch from d40470e to 34a86f7 Compare February 6, 2025 13:09

rustbot added the A-tidy Area: The tidy tool label Feb 6, 2025

This comment has been minimized.

Sign in to view

bjorn3 force-pushed the separate_alloctest_crate branch from 34a86f7 to 68120bf Compare February 6, 2025 14:02

bjorn3 mentioned this pull request Feb 6, 2025

impl ... for Box<CoreType> in alloc should not require #[cfg(not(test))] #135100

Open

This comment has been minimized.

Sign in to view

bjorn3 force-pushed the separate_alloctest_crate branch from 68120bf to 8f1c7c3 Compare February 6, 2025 17:32

cuviper reviewed Feb 10, 2025

View reviewed changes

library/alloctests/lib.rs Show resolved Hide resolved

cuviper reviewed Feb 10, 2025

View reviewed changes

library/alloctests/lib.rs Show resolved Hide resolved

bjorn3 force-pushed the separate_alloctest_crate branch from 8f1c7c3 to 1726670 Compare February 13, 2025 15:38

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 13, 2025

workingjubilee closed this Feb 14, 2025

workingjubilee reopened this Feb 14, 2025

workingjubilee mentioned this pull request Feb 14, 2025

Rollup of 13 pull requests #136998

Closed

bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 14, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Mar 6, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 6, 2025

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 7, 2025

bjorn3 added 5 commits March 7, 2025 19:11

Move all alloc integration tests to a new alloctests crate

fb04372

Move most Rc tests to alloctests

be1e0b7

Move last remaining Rc test to alloctests

701bedc

Fully test the alloc crate through alloctests

ae5687e

For the tests that make use of internal implementation details, we include the module to test using #[path] in alloctests now.

Add comments

22d0440

bjorn3 force-pushed the separate_alloctest_crate branch from bf6ede0 to 22d0440 Compare March 7, 2025 19:11

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 7, 2025

compiler-errors mentioned this pull request Mar 7, 2025

Rollup of 10 pull requests #138180

Closed

compiler-errors mentioned this pull request Mar 7, 2025

Rollup of 8 pull requests #138185

Closed

jhpratt mentioned this pull request Mar 8, 2025

Rollup of 5 pull requests #138208

Merged

bors merged commit 720eacf into rust-lang:master Mar 8, 2025
6 checks passed

rustbot added this to the 1.87.0 milestone Mar 8, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Put the alloc unit tests in a separate alloctests package #136642

Put the alloc unit tests in a separate alloctests package #136642

bjorn3 commented Feb 6, 2025 •

edited

Loading

rustbot commented Feb 6, 2025

rustbot commented Feb 6, 2025

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

bors commented Feb 7, 2025

cuviper commented Feb 13, 2025

bors commented Feb 13, 2025

workingjubilee commented Feb 14, 2025

cuviper commented Mar 6, 2025

bors commented Mar 6, 2025

bors commented Mar 7, 2025

bjorn3 commented Mar 7, 2025

bors commented Mar 7, 2025

Put the alloc unit tests in a separate alloctests package #136642

Put the alloc unit tests in a separate alloctests package #136642

Conversation

bjorn3 commented Feb 6, 2025 • edited Loading

rustbot commented Feb 6, 2025

rustbot commented Feb 6, 2025

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

bors commented Feb 7, 2025

cuviper commented Feb 13, 2025

bors commented Feb 13, 2025

workingjubilee commented Feb 14, 2025

cuviper commented Mar 6, 2025

bors commented Mar 6, 2025

bors commented Mar 7, 2025

bjorn3 commented Mar 7, 2025

bors commented Mar 7, 2025

bjorn3 commented Feb 6, 2025 •

edited

Loading