Couple of minor cleanups to the diagnostic infrastructure #136636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @petrochenkov. Use |
bjorn3
commented
Feb 6, 2025
| @@ -1024,7 +1024,7 @@ pub fn describe_flag_categories(early_dcx: &EarlyDiagCtxt, matches: &Matches) -> | |||
| let wall = matches.opt_strs("W"); | |||
| if wall.iter().any(|x| *x == "all") { | |||
| print_wall_help(); | |||
| rustc_errors::FatalError.raise(); | |||
| return true; | |||
There was a problem hiding this comment.
Returning true from describe_flag_categories also causes a silent exit.
bjorn3
commented
Feb 6, 2025
| false, | ||
| ); | ||
| let fallback_bundle = | ||
| rustc_errors::fallback_fluent_bundle(vec![crate::DEFAULT_LOCALE_RESOURCE], false); |
There was a problem hiding this comment.
Duplicating a resource has no effect at all.
This comment has been minimized.
This comment has been minimized.
|
☔ The latest upstream changes (presumably #136471) made this pull request unmergeable. Please resolve the merge conflicts. |
compiler-errors
approved these changes
Feb 6, 2025
|
r? compiler-errors @bors r+ |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 6, 2025
…rrors Couple of minor cleanups to the diagnostic infrastructure
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 6, 2025
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#133925 (disallow `repr()` on invalid items) - rust-lang#135549 (Document some safety constraints and use more safe wrappers) - rust-lang#136069 (Simplify slice indexing in next trait solver) - rust-lang#136152 (Stabilize `map_many_mut` feature) - rust-lang#136219 (Misc. `rustc_hir` cleanups 🧹) - rust-lang#136580 (Couple of changes to run rustc in miri) - rust-lang#136636 (Couple of minor cleanups to the diagnostic infrastructure) - rust-lang#136645 (Clippy subtree update) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 7, 2025
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#133925 (disallow `repr()` on invalid items) - rust-lang#136069 (Simplify slice indexing in next trait solver) - rust-lang#136152 (Stabilize `map_many_mut` feature) - rust-lang#136219 (Misc. `rustc_hir` cleanups 🧹) - rust-lang#136580 (Couple of changes to run rustc in miri) - rust-lang#136636 (Couple of minor cleanups to the diagnostic infrastructure) - rust-lang#136645 (Clippy subtree update) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 7, 2025
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#133925 (disallow `repr()` on invalid items) - rust-lang#136069 (Simplify slice indexing in next trait solver) - rust-lang#136152 (Stabilize `map_many_mut` feature) - rust-lang#136219 (Misc. `rustc_hir` cleanups 🧹) - rust-lang#136580 (Couple of changes to run rustc in miri) - rust-lang#136636 (Couple of minor cleanups to the diagnostic infrastructure) - rust-lang#136645 (Clippy subtree update) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 7, 2025
Rollup merge of rust-lang#136636 - bjorn3:error_cleanup, r=compiler-errors Couple of minor cleanups to the diagnostic infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.