Rename and Move some UI tests to more suitable subdirs #136536

DuskyElf · 2025-02-04T11:41:15Z

Tracking Issue: #73494

Affected Tests

tests/ui/issues/issue-48838.rs -> tests/ui/enum/closure-in-enum-issue-48838.rs assign a Closure in Enum #48838
tests/ui/issues/issue-40350.rs -> tests/ui/enum/enum-inside-enum-issue-40350.rs Enum inside enum - assertion failed: !self.in_variant #40350
tests/ui/issues/issue-41272.rs -> tests/ui/expr/if/if-let-no-match-guards-issue-41272.rs if clauses following an if let are compiled to match guards #41272
tests/ui/issues/issue-40408.rs -> tests/ui/lexer/floating-point-0e10-issue-40408.rs 0e+10 is invalid whereas 00e+10 is valid #40408
tests/ui/issues/issue-40136.rs -> tests/ui/macros/const-expr-invocations-issue-40136.rs ICE: Defn conflict #40136
tests/ui/issues/issue-40845.rs -> tests/ui/macros/macros-in-trait-positions-issue-40845.rs Nonexisting macro is silently accepted in trait definition block #40845
tests/ui/issues/issue-41213.rs -> tests/ui/match/enum-and-break-in-match-issue-41213.rs ICE when break and enum variants mixed in match arms #41213
tests/ui/issues/issue-40782.rs -> tests/ui/suggestions/for-loop-missing-in.rs Improve error message for incorrect 'for' input #40782
tests/ui/issues/issue-40827.rs -> tests/ui/trait-bounds/deep-level-Send-bound-check-issue-40827.rs Infinite recursion error instead of trait bound error #40827
tests/ui/issues/issue-40610.rs -> tests/ui/typeck/coercion-check-for-addition-issue-40610.rs ICE when trying to Add a Vec and vec![] on 1.17 nightly #40610
tests/ui/issues/issue-40883.rs -> tests/ui/codegen/StackColoring-not-blowup-stack-issue-40883.rs Linear stack blowup with multiple Vec::push of big struct with destructor #40883
tests/ui/issues/issue-40861.rs -> tests/ui/typeck/coercion-check-for-indexing-expression-issue-40861.rs Repeated coercion ICE for an erroring indexing expression since 1.9. #40861
tests/ui/issues/issue-41139.rs -> tests/ui/typeck/unsized-rvalue-issue-41139.rs Compilation fails without error message #41139
tests/ui/issues/issue-40749.rs -> tests/ui/wf/range-expr-root-of-constant-issue-40749.rs Nightly compiler error regression for struct array field #40749
tests/ui/issues/issue-40235.rs -> tests/ui/while/while-let-scope-issue-40235.rs Rustc scoping regression #40235

rustbot · 2025-02-04T11:41:24Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jieyouxu (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

@rustbot author: the review is finished, PR author should check the comments and take action accordingly
@rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

jieyouxu

Thanks, two suggestions but LGTM otherwise.

tests/ui/match/enum-and-break-in-match-issue-41213.rs

tests/ui/while/while-let-scope-issue-40235.rs

DuskyElf · 2025-02-04T16:12:15Z

Thanks, that makes sense. I'd push a quick-fix ;)

tests/ui/match/enum-and-break-in-match-issue-41213.rs and tests/ui/while/while-let-scope-issue-40235.rs doesn't need to be run.

DuskyElf · 2025-02-04T16:21:49Z

@rustbot ready

jieyouxu

Cool

jieyouxu · 2025-02-05T10:05:45Z

@bors r+ rollup

bors · 2025-02-05T10:05:49Z

📌 Commit 5b981a8 has been approved by jieyouxu

It is now in the queue for this repository.

Rename and Move some UI tests to more suitable subdirs ## Affected Tests - tests/ui/issues/issue-48838.rs -> tests/ui/enum/closure-in-enum-issue-48838.rs rust-lang#48838 - tests/ui/issues/issue-40350.rs -> tests/ui/enum/enum-inside-enum-issue-40350.rs rust-lang#40350 - tests/ui/issues/issue-41272.rs -> tests/ui/expr/if/if-let-no-match-guards-issue-41272.rs rust-lang#41272 - tests/ui/issues/issue-40408.rs -> tests/ui/lexer/floating-point-0e10-issue-40408.rs rust-lang#40408 - tests/ui/issues/issue-40136.rs -> tests/ui/macros/const-expr-invocations-issue-40136.rs rust-lang#40136 - tests/ui/issues/issue-40845.rs -> tests/ui/macros/macros-in-trait-positions-issue-40845.rs rust-lang#40845 - tests/ui/issues/issue-41213.rs -> tests/ui/match/enum-and-break-in-match-issue-41213.rs rust-lang#41213 - tests/ui/issues/issue-40782.rs -> tests/ui/suggestions/for-loop-missing-in.rs rust-lang#40782 - tests/ui/issues/issue-40827.rs -> tests/ui/trait-bounds/deep-level-Send-bound-check-issue-40827.rs rust-lang#40827 - tests/ui/issues/issue-40610.rs -> tests/ui/typeck/coercion-check-for-addition-issue-40610.rs rust-lang#40610 - tests/ui/issues/issue-40883.rs -> tests/ui/codegen/StackColoring-not-blowup-stack-issue-40883.rs rust-lang#40883 - tests/ui/issues/issue-40861.rs -> tests/ui/typeck/coercion-check-for-indexing-expression-issue-40861.rs rust-lang#40861 - tests/ui/issues/issue-41139.rs -> tests/ui/typeck/unsized-rvalue-issue-41139.rs rust-lang#41139 - tests/ui/issues/issue-40749.rs -> tests/ui/wf/range-expr-root-of-constant-issue-40749.rs rust-lang#40749 - tests/ui/issues/issue-40235.rs -> tests/ui/while/while-let-scope-issue-40235.rs rust-lang#40235

Rollup of 12 pull requests Successful merges: - rust-lang#132547 (cg_gcc: Directly use rustc_abi instead of reexports) - rust-lang#135572 (tests: Port `split-debuginfo` to rmake.rs) - rust-lang#135964 (Make cenum_impl_drop_cast a hard error) - rust-lang#136154 (Use +secure-plt for powerpc-unknown-linux-gnu{,spe}) - rust-lang#136304 (Reject negative literals for unsigned or char types in pattern ranges and literals) - rust-lang#136418 (uefi: process: Add support for command environment variables) - rust-lang#136449 (std: move network code into `sys`) - rust-lang#136517 (implement inherent str constructors) - rust-lang#136536 (Rename and Move some UI tests to more suitable subdirs) - rust-lang#136537 (Update `compiler-builtins` to 0.1.145) - rust-lang#136555 (Rename `slice::take...` methods to `split_off...`) - rust-lang#136567 (Arbitrary self types v2: recursion test) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#136536 - DuskyElf:master, r=jieyouxu Rename and Move some UI tests to more suitable subdirs ## Affected Tests - tests/ui/issues/issue-48838.rs -> tests/ui/enum/closure-in-enum-issue-48838.rs rust-lang#48838 - tests/ui/issues/issue-40350.rs -> tests/ui/enum/enum-inside-enum-issue-40350.rs rust-lang#40350 - tests/ui/issues/issue-41272.rs -> tests/ui/expr/if/if-let-no-match-guards-issue-41272.rs rust-lang#41272 - tests/ui/issues/issue-40408.rs -> tests/ui/lexer/floating-point-0e10-issue-40408.rs rust-lang#40408 - tests/ui/issues/issue-40136.rs -> tests/ui/macros/const-expr-invocations-issue-40136.rs rust-lang#40136 - tests/ui/issues/issue-40845.rs -> tests/ui/macros/macros-in-trait-positions-issue-40845.rs rust-lang#40845 - tests/ui/issues/issue-41213.rs -> tests/ui/match/enum-and-break-in-match-issue-41213.rs rust-lang#41213 - tests/ui/issues/issue-40782.rs -> tests/ui/suggestions/for-loop-missing-in.rs rust-lang#40782 - tests/ui/issues/issue-40827.rs -> tests/ui/trait-bounds/deep-level-Send-bound-check-issue-40827.rs rust-lang#40827 - tests/ui/issues/issue-40610.rs -> tests/ui/typeck/coercion-check-for-addition-issue-40610.rs rust-lang#40610 - tests/ui/issues/issue-40883.rs -> tests/ui/codegen/StackColoring-not-blowup-stack-issue-40883.rs rust-lang#40883 - tests/ui/issues/issue-40861.rs -> tests/ui/typeck/coercion-check-for-indexing-expression-issue-40861.rs rust-lang#40861 - tests/ui/issues/issue-41139.rs -> tests/ui/typeck/unsized-rvalue-issue-41139.rs rust-lang#41139 - tests/ui/issues/issue-40749.rs -> tests/ui/wf/range-expr-root-of-constant-issue-40749.rs rust-lang#40749 - tests/ui/issues/issue-40235.rs -> tests/ui/while/while-let-scope-issue-40235.rs rust-lang#40235

Rename and Move some UI tests to more suitable subdirs

2431977

rustbot assigned jieyouxu Feb 4, 2025

jieyouxu requested changes Feb 4, 2025

View reviewed changes

tests/ui/match/enum-and-break-in-match-issue-41213.rs Show resolved Hide resolved

tests/ui/while/while-let-scope-issue-40235.rs Show resolved Hide resolved

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 4, 2025

Quickfix //@ check-pass is enough

5b981a8

tests/ui/match/enum-and-break-in-match-issue-41213.rs and tests/ui/while/while-let-scope-issue-40235.rs doesn't need to be run.

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 4, 2025

jieyouxu approved these changes Feb 5, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 5, 2025

jieyouxu mentioned this pull request Feb 5, 2025

Rollup of 12 pull requests #136569

Closed

This was referenced Feb 5, 2025

Rollup of 11 pull requests #136570

Closed

Rollup of 12 pull requests #136572

Merged

bors merged commit 41e93ab into rust-lang:master Feb 6, 2025
6 checks passed

rustbot added this to the 1.86.0 milestone Feb 6, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rename and Move some UI tests to more suitable subdirs #136536

Rename and Move some UI tests to more suitable subdirs #136536

DuskyElf commented Feb 4, 2025 •

edited

Loading

rustbot commented Feb 4, 2025

jieyouxu left a comment

DuskyElf commented Feb 4, 2025

DuskyElf commented Feb 4, 2025

jieyouxu left a comment

jieyouxu commented Feb 5, 2025

bors commented Feb 5, 2025

Rename and Move some UI tests to more suitable subdirs #136536

Rename and Move some UI tests to more suitable subdirs #136536

Conversation

DuskyElf commented Feb 4, 2025 • edited Loading

Affected Tests

rustbot commented Feb 4, 2025

jieyouxu left a comment

Choose a reason for hiding this comment

DuskyElf commented Feb 4, 2025

DuskyElf commented Feb 4, 2025

jieyouxu left a comment

Choose a reason for hiding this comment

jieyouxu commented Feb 5, 2025

bors commented Feb 5, 2025

DuskyElf commented Feb 4, 2025 •

edited

Loading