Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 5 pull requests #136111

Closed
wants to merge 14 commits into from
Closed

Conversation

jhpratt
Copy link
Member

@jhpratt jhpratt commented Jan 27, 2025

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

jhpratt and others added 14 commits January 26, 2025 04:57
Add some tracing to core bootstrap logic

Follow-up to rust-lang#135391.

### Summary

Add some initial tracing logging to bootstrap, focused on the core logic (in this PR).

Also:

- Adjusted tracing-tree style to not use indent lines (I found that more distracting than helpful).
- Avoid glob-importing `tracing` items.
- Improve the rustc-dev-guide docs on bootstrap tracing.

### Example output

```bash
$ BOOTSTRAP_TRACING=bootstrap=TRACE ./x check src/bootstrap
```

![Example bootstrap tracing output](https://github.com/user-attachments/assets/0be39042-0822-44b6-9451-30427cfea156)

r? bootstrap
…mulacrum

Upgrade elsa to the newest version.

This was locked to 1.7.1 because of an error in the elsa release process that has since been fixed. Upgrading has the advantage that the elsa code runs properly in miri, at least with tree borrows.

This was spawned from rust-lang#135870 (comment)
…etrochenkov

rustc_ast: replace some len-checks + indexing with slice patterns etc.
triagebot: set myself on vacation

Will be back 02-01.
@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-rustc-dev-guide Area: rustc-dev-guide S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jan 27, 2025
@jhpratt
Copy link
Member Author

jhpratt commented Jan 27, 2025

@bors r+ rollup=never p=5

@bors
Copy link
Contributor

bors commented Jan 27, 2025

📌 Commit a953137 has been approved by jhpratt

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 27, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 27, 2025
Rollup of 5 pull requests

Successful merges:

 - rust-lang#135807 (Implement phantom variance markers)
 - rust-lang#136091 (Add some tracing to core bootstrap logic)
 - rust-lang#136094 (Upgrade elsa to the newest version.)
 - rust-lang#136097 (rustc_ast: replace some len-checks + indexing with slice patterns etc.)
 - rust-lang#136101 (triagebot: set myself on vacation)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
Copy link
Contributor

bors commented Jan 27, 2025

⌛ Testing commit a953137 with merge d21b9c2...

@rust-log-analyzer
Copy link
Collaborator

The job dist-i686-linux failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
   8: 0xee903fcb - std::panicking::default_hook::{{closure}}::hf9797f89271b39b8
                       at /rustc/d21b9c2d78ca60afe98a7e33e771c75360123548/library/std/src/panicking.rs:298:22
   9: 0xee903e1e - std::panicking::default_hook::hd73f0fdf0c98d4e4
                       at /rustc/d21b9c2d78ca60afe98a7e33e771c75360123548/library/std/src/panicking.rs:325:9
  10: 0xe804d78c - <std[c056b586f2c73c49]::panicking::default_hook as core[46011a1357472d7c]::ops::function::Fn<(&std[c056b586f2c73c49]::panic::PanicHookInfo,)>>::call
  11: 0xe8028483 - <alloc[d816e318e664a7e2]::boxed::Box<dyn for<'a, 'b> core[46011a1357472d7c]::ops::function::Fn<(&'a std[c056b586f2c73c49]::panic::PanicHookInfo<'b>,), Output = ()> + core[46011a1357472d7c]::marker::Sync + core[46011a1357472d7c]::marker::Send> as core[46011a1357472d7c]::ops::function::Fn<(&std[c056b586f2c73c49]::panic::PanicHookInfo,)>>::call
  12: 0xe802857b - <alloc[d816e318e664a7e2]::boxed::Box<rustc_driver_impl[42908add318bcb02]::install_ice_hook::{closure#1}> as core[46011a1357472d7c]::ops::function::Fn<(&dyn for<'a, 'b> core[46011a1357472d7c]::ops::function::Fn<(&'a std[c056b586f2c73c49]::panic::PanicHookInfo<'b>,), Output = ()> + core[46011a1357472d7c]::marker::Sync + core[46011a1357472d7c]::marker::Send, &std[c056b586f2c73c49]::panic::PanicHookInfo)>>::call
  13: 0xe804be59 - std[c056b586f2c73c49]::panicking::update_hook::<alloc[d816e318e664a7e2]::boxed::Box<rustc_driver_impl[42908add318bcb02]::install_ice_hook::{closure#1}>>::{closure#0}
  14: 0xee904b48 - <alloc::boxed::Box<F,A> as core::ops::function::Fn<Args>>::call::h28f84db71c5a35d5
  15: 0xee904b48 - std::panicking::rust_panic_with_hook::hba4e1ce57627751e
                       at /rustc/d21b9c2d78ca60afe98a7e33e771c75360123548/library/std/src/panicking.rs:839:13
  16: 0xee9047f4 - std::panicking::begin_panic_handler::{{closure}}::hf5ec883ade6bbaf3
                       at /rustc/d21b9c2d78ca60afe98a7e33e771c75360123548/library/std/src/panicking.rs:704:13
---
  19: 0xe7f2c230 - core::panicking::panic_fmt::h1c7a64c924700775
                       at /rustc/d21b9c2d78ca60afe98a7e33e771c75360123548/library/core/src/panicking.rs:75:14
  20: 0xe7f2c45f - core::panicking::panic_bounds_check::h37c2486bd6b809b8
                       at /rustc/d21b9c2d78ca60afe98a7e33e771c75360123548/library/core/src/panicking.rs:273:5
  21: 0xecbf6067 - <rustc_data_structures[40968251b6b58234]::sync::vec::AppendOnlyIndexVec<rustc_span[2812a29c68dcaaab]::def_id::LocalDefId, rustc_span[2812a29c68dcaaab]::span_encoding::Span>>::push
  22: 0xecaeadf7 - <rustc_resolve[764be07e64d23183]::Resolver>::create_def
  23: 0xecb6e17b - <rustc_resolve[764be07e64d23183]::def_collector::DefCollector>::create_def
  24: 0xecb6f73d - <rustc_resolve[764be07e64d23183]::def_collector::DefCollector as rustc_ast[b07969346e3cbf4e]::visit::Visitor>::visit_expr
  25: 0xecb8c2ef - <rustc_expand[b62cf2e57ab41d8a]::expand::AstFragment>::visit_with::<rustc_resolve[764be07e64d23183]::def_collector::DefCollector>
  26: 0xecb6df37 - rustc_resolve[764be07e64d23183]::def_collector::collect_definitions
  27: 0xecadcc17 - <rustc_resolve[764be07e64d23183]::Resolver as rustc_expand[b62cf2e57ab41d8a]::base::ResolverExpand>::visit_ast_fragment_with_placeholders
  28: 0xedcf4f17 - <rustc_expand[b62cf2e57ab41d8a]::expand::MacroExpander>::collect_invocations
  29: 0xedcf2618 - <rustc_expand[b62cf2e57ab41d8a]::expand::MacroExpander>::fully_expand_fragment
  30: 0xedceedf0 - <rustc_expand[b62cf2e57ab41d8a]::expand::MacroExpander>::expand_crate
  31: 0xe82fef6e - <rustc_session[5b244fde849379a5]::session::Session>::time::<rustc_ast[b07969346e3cbf4e]::ast::Crate, rustc_interface[47834e5f35668a1b]::passes::configure_and_expand::{closure#1}>
  32: 0xe8274bb5 - rustc_interface[47834e5f35668a1b]::passes::resolver_for_lowering_raw
  33: 0xecfa76e6 - rustc_query_impl[3e76e7a17b033b02]::plumbing::__rust_begin_short_backtrace::<rustc_query_impl[3e76e7a17b033b02]::query_impl::resolver_for_lowering_raw::dynamic_query::{closure#2}::{closure#0}, rustc_middle[1e1d7f480943b278]::query::erase::Erased<[u8; 8usize]>>
  34: 0xed145300 - <rustc_query_impl[3e76e7a17b033b02]::query_impl::resolver_for_lowering_raw::dynamic_query::{closure#2} as core[46011a1357472d7c]::ops::function::FnOnce<(rustc_middle[1e1d7f480943b278]::ty::context::TyCtxt, ())>>::call_once
  35: 0xecec2bcb - rustc_query_system[762892374c2f03e3]::query::plumbing::try_execute_query::<rustc_query_impl[3e76e7a17b033b02]::DynamicConfig<rustc_query_system[762892374c2f03e3]::query::caches::SingleCache<rustc_middle[1e1d7f480943b278]::query::erase::Erased<[u8; 8usize]>>, false, false, false>, rustc_query_impl[3e76e7a17b033b02]::plumbing::QueryCtxt, false>
  36: 0xed148818 - rustc_query_impl[3e76e7a17b033b02]::query_impl::resolver_for_lowering_raw::get_query_non_incr::__rust_end_short_backtrace
  37: 0xee1a19f5 - <rustc_middle[1e1d7f480943b278]::ty::context::TyCtxt>::resolver_for_lowering
  38: 0xe8272560 - rustc_interface[47834e5f35668a1b]::passes::early_lint_checks
  39: 0xecfa393f - rustc_query_impl[3e76e7a17b033b02]::plumbing::__rust_begin_short_backtrace::<rustc_query_impl[3e76e7a17b033b02]::query_impl::early_lint_checks::dynamic_query::{closure#2}::{closure#0}, rustc_middle[1e1d7f480943b278]::query::erase::Erased<[u8; 0usize]>>
  40: 0xed238d9a - <rustc_query_impl[3e76e7a17b033b02]::query_impl::early_lint_checks::dynamic_query::{closure#2} as core[46011a1357472d7c]::ops::function::FnOnce<(rustc_middle[1e1d7f480943b278]::ty::context::TyCtxt, ())>>::call_once
  41: 0xecebea3e - rustc_query_system[762892374c2f03e3]::query::plumbing::try_execute_query::<rustc_query_impl[3e76e7a17b033b02]::DynamicConfig<rustc_query_system[762892374c2f03e3]::query::caches::SingleCache<rustc_middle[1e1d7f480943b278]::query::erase::Erased<[u8; 0usize]>>, false, false, false>, rustc_query_impl[3e76e7a17b033b02]::plumbing::QueryCtxt, false>
  42: 0xed147f30 - rustc_query_impl[3e76e7a17b033b02]::query_impl::early_lint_checks::get_query_non_incr::__rust_end_short_backtrace
  43: 0xec854074 - rustc_ast_lowering[330b33947b275214]::lower_to_hir
  44: 0xecfa94aa - rustc_query_impl[3e76e7a17b033b02]::plumbing::__rust_begin_short_backtrace::<rustc_query_impl[3e76e7a17b033b02]::query_impl::hir_crate::dynamic_query::{closure#2}::{closure#0}, rustc_middle[1e1d7f480943b278]::query::erase::Erased<[u8; 4usize]>>
  45: 0xed0fa10a - <rustc_query_impl[3e76e7a17b033b02]::query_impl::hir_crate::dynamic_query::{closure#2} as core[46011a1357472d7c]::ops::function::FnOnce<(rustc_middle[1e1d7f480943b278]::ty::context::TyCtxt, ())>>::call_once
  46: 0xecec15c9 - rustc_query_system[762892374c2f03e3]::query::plumbing::try_execute_query::<rustc_query_impl[3e76e7a17b033b02]::DynamicConfig<rustc_query_system[762892374c2f03e3]::query::caches::SingleCache<rustc_middle[1e1d7f480943b278]::query::erase::Erased<[u8; 4usize]>>, false, false, false>, rustc_query_impl[3e76e7a17b033b02]::plumbing::QueryCtxt, false>
  47: 0xed149418 - rustc_query_impl[3e76e7a17b033b02]::query_impl::hir_crate::get_query_non_incr::__rust_end_short_backtrace
  48: 0xe826ff75 - <rustc_middle[1e1d7f480943b278]::hir::provide::{closure#1} as core[46011a1357472d7c]::ops::function::FnOnce<(rustc_middle[1e1d7f480943b278]::ty::context::TyCtxt, rustc_span[2812a29c68dcaaab]::def_id::LocalDefId)>>::call_once
  49: 0xecfa4bba - rustc_query_impl[3e76e7a17b033b02]::plumbing::__rust_begin_short_backtrace::<rustc_query_impl[3e76e7a17b033b02]::query_impl::opt_hir_owner_nodes::dynamic_query::{closure#2}::{closure#0}, rustc_middle[1e1d7f480943b278]::query::erase::Erased<[u8; 4usize]>>
  50: 0xed1f9df1 - <rustc_query_impl[3e76e7a17b033b02]::query_impl::opt_hir_owner_nodes::dynamic_query::{closure#2} as core[46011a1357472d7c]::ops::function::FnOnce<(rustc_middle[1e1d7f480943b278]::ty::context::TyCtxt, rustc_span[2812a29c68dcaaab]::def_id::LocalDefId)>>::call_once
  51: 0xecf44559 - rustc_query_system[762892374c2f03e3]::query::plumbing::try_execute_query::<rustc_query_impl[3e76e7a17b033b02]::DynamicConfig<rustc_data_structures[40968251b6b58234]::vec_cache::VecCache<rustc_span[2812a29c68dcaaab]::def_id::LocalDefId, rustc_middle[1e1d7f480943b278]::query::erase::Erased<[u8; 4usize]>, rustc_query_system[762892374c2f03e3]::dep_graph::graph::DepNodeIndex>, false, false, false>, rustc_query_impl[3e76e7a17b033b02]::plumbing::QueryCtxt, false>
  52: 0xed14a6d3 - rustc_query_impl[3e76e7a17b033b02]::query_impl::opt_hir_owner_nodes::get_query_non_incr::__rust_end_short_backtrace
  53: 0xee2e2cda - rustc_middle[1e1d7f480943b278]::query::plumbing::query_get_at::<rustc_data_structures[40968251b6b58234]::vec_cache::VecCache<rustc_span[2812a29c68dcaaab]::def_id::LocalDefId, rustc_middle[1e1d7f480943b278]::query::erase::Erased<[u8; 4usize]>, rustc_query_system[762892374c2f03e3]::dep_graph::graph::DepNodeIndex>>
  54: 0xee2d6aab - <rustc_middle[1e1d7f480943b278]::hir::map::Map>::get_module
  55: 0xee2dc759 - rustc_middle[1e1d7f480943b278]::hir::map::hir_crate_items
  56: 0xecfa257f - rustc_query_impl[3e76e7a17b033b02]::plumbing::__rust_begin_short_backtrace::<rustc_query_impl[3e76e7a17b033b02]::query_impl::hir_crate_items::dynamic_query::{closure#2}::{closure#0}, rustc_middle[1e1d7f480943b278]::query::erase::Erased<[u8; 4usize]>>
  57: 0xed1f76aa - <rustc_query_impl[3e76e7a17b033b02]::query_impl::hir_crate_items::dynamic_query::{closure#2} as core[46011a1357472d7c]::ops::function::FnOnce<(rustc_middle[1e1d7f480943b278]::ty::context::TyCtxt, ())>>::call_once
  58: 0xecec15c9 - rustc_query_system[762892374c2f03e3]::query::plumbing::try_execute_query::<rustc_query_impl[3e76e7a17b033b02]::DynamicConfig<rustc_query_system[762892374c2f03e3]::query::caches::SingleCache<rustc_middle[1e1d7f480943b278]::query::erase::Erased<[u8; 4usize]>>, false, false, false>, rustc_query_impl[3e76e7a17b033b02]::plumbing::QueryCtxt, false>
  59: 0xed149728 - rustc_query_impl[3e76e7a17b033b02]::query_impl::hir_crate_items::get_query_non_incr::__rust_end_short_backtrace
  60: 0x613020dd - <rustc_session[5b244fde849379a5]::session::Session>::time::<core[46011a1357472d7c]::result::Result<(), rustc_span[2812a29c68dcaaab]::ErrorGuaranteed>, rustdoc[cf3f8fcbca2a8caa]::core::run_global_ctxt::{closure#0}>
  61: 0x61728e04 - rustdoc[cf3f8fcbca2a8caa]::core::run_global_ctxt
  62: 0x61302e02 - <rustc_session[5b244fde849379a5]::session::Session>::time::<(rustdoc[cf3f8fcbca2a8caa]::clean::types::Crate, rustdoc[cf3f8fcbca2a8caa]::config::RenderOptions, rustdoc[cf3f8fcbca2a8caa]::formats::cache::Cache), rustdoc[cf3f8fcbca2a8caa]::main_args::{closure#2}::{closure#0}::{closure#0}>
  63: 0x615c2c0b - <std[c056b586f2c73c49]::thread::local::LocalKey<core[46011a1357472d7c]::cell::Cell<*const ()>>>::with::<rustc_middle[1e1d7f480943b278]::ty::context::tls::enter_context<<rustc_middle[1e1d7f480943b278]::ty::context::TyCtxt>::create_global_ctxt<(), rustc_interface[47834e5f35668a1b]::passes::create_and_enter_global_ctxt<(), rustdoc[cf3f8fcbca2a8caa]::main_args::{closure#2}::{closure#0}>::{closure#2}::{closure#0}>::{closure#3}, ()>::{closure#0}, ()>
  64: 0x6142833b - <rustc_interface[47834e5f35668a1b]::passes::create_and_enter_global_ctxt<(), rustdoc[cf3f8fcbca2a8caa]::main_args::{closure#2}::{closure#0}>::{closure#2} as core[46011a1357472d7c]::ops::function::FnOnce<(&rustc_session[5b244fde849379a5]::session::Session, rustc_middle[1e1d7f480943b278]::ty::context::CurrentGcx, &std[c056b586f2c73c49]::sync::once_lock::OnceLock<rustc_middle[1e1d7f480943b278]::ty::context::GlobalCtxt>, &rustc_data_structures[40968251b6b58234]::sync::worker_local::WorkerLocal<rustc_middle[1e1d7f480943b278]::arena::Arena>, &rustc_data_structures[40968251b6b58234]::sync::worker_local::WorkerLocal<rustc_hir[1ed6964ad054ba09]::Arena>, rustdoc[cf3f8fcbca2a8caa]::main_args::{closure#2}::{closure#0})>>::call_once::{shim:vtable#0}
  65: 0x6140e9b7 - rustc_interface[47834e5f35668a1b]::passes::create_and_enter_global_ctxt::<(), rustdoc[cf3f8fcbca2a8caa]::main_args::{closure#2}::{closure#0}>
  66: 0x614f0972 - rustc_interface[47834e5f35668a1b]::interface::run_compiler::<(), rustdoc[cf3f8fcbca2a8caa]::main_args::{closure#2}>::{closure#1}
  67: 0x614cb16a - <scoped_tls[8911f09bc7ab1804]::ScopedKey<rustc_span[2812a29c68dcaaab]::SessionGlobals>>::set::<rustc_interface[47834e5f35668a1b]::util::run_in_thread_with_globals<rustc_interface[47834e5f35668a1b]::util::run_in_thread_pool_with_globals<rustc_interface[47834e5f35668a1b]::interface::run_compiler<(), rustdoc[cf3f8fcbca2a8caa]::main_args::{closure#2}>::{closure#1}, ()>::{closure#0}, ()>::{closure#0}::{closure#0}::{closure#0}, ()>
  68: 0x613eb7ab - rustc_span[2812a29c68dcaaab]::create_session_globals_then::<(), rustc_interface[47834e5f35668a1b]::util::run_in_thread_with_globals<rustc_interface[47834e5f35668a1b]::util::run_in_thread_pool_with_globals<rustc_interface[47834e5f35668a1b]::interface::run_compiler<(), rustdoc[cf3f8fcbca2a8caa]::main_args::{closure#2}>::{closure#1}, ()>::{closure#0}, ()>::{closure#0}::{closure#0}::{closure#0}>
  69: 0x614e3358 - std[c056b586f2c73c49]::sys::backtrace::__rust_begin_short_backtrace::<rustc_interface[47834e5f35668a1b]::util::run_in_thread_with_globals<rustc_interface[47834e5f35668a1b]::util::run_in_thread_pool_with_globals<rustc_interface[47834e5f35668a1b]::interface::run_compiler<(), rustdoc[cf3f8fcbca2a8caa]::main_args::{closure#2}>::{closure#1}, ()>::{closure#0}, ()>::{closure#0}::{closure#0}, ()>
  70: 0x615e184f - <<std[c056b586f2c73c49]::thread::Builder>::spawn_unchecked_<rustc_interface[47834e5f35668a1b]::util::run_in_thread_with_globals<rustc_interface[47834e5f35668a1b]::util::run_in_thread_pool_with_globals<rustc_interface[47834e5f35668a1b]::interface::run_compiler<(), rustdoc[cf3f8fcbca2a8caa]::main_args::{closure#2}>::{closure#1}, ()>::{closure#0}, ()>::{closure#0}::{closure#0}, ()>::{closure#1} as core[46011a1357472d7c]::ops::function::FnOnce<()>>::call_once::{shim:vtable#0}
  71: 0xee90eff0 - <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once::h80c9bd6c304722e1
                       at /rustc/d21b9c2d78ca60afe98a7e33e771c75360123548/library/alloc/src/boxed.rs:2013:9
  72: 0xee90eff0 - <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once::hea1600d2256f4168
  73: 0xee90eff0 - std::sys::pal::unix::thread::Thread::new::thread_start::h5ac78829c739e32c
                       at /rustc/d21b9c2d78ca60afe98a7e33e771c75360123548/library/std/src/sys/pal/unix/thread.rs:106:17
  74: 0xe77e6bbc - start_thread
  75: 0xe76b527e - __clone
  75: 0xe76b527e - __clone
  76:        0x0 - <unknown>

error: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust/issues/new?labels=C-bug%2C+I-ICE%2C+T-rustdoc&template=ice.md
note: please make sure that you have updated to the latest nightly

warning: the ICE couldn't be written to `/checkout/rustc-ice-2025-01-27T02_31_17-55678.txt`: Read-only file system (os error 30)


note: rustc 1.86.0-nightly (d21b9c2d7 2025-01-27) running on i686-unknown-linux-gnu

note: compiler flags: --crate-type lib -C symbol-mangling-version=legacy -Z unstable-options -C linker=clang -Z crate-attr=doc(html_root_url="https://doc.rust-lang.org/nightly/") -Z crate-attr=warn(rust_2018_idioms) -Z unstable-options -Z force-unstable-if-unmarked
note: some of the compiler flags provided by cargo are hidden

query stack during panic:
#0 [resolver_for_lowering_raw] getting the resolver for lowering
#0 [resolver_for_lowering_raw] getting the resolver for lowering
#1 [early_lint_checks] perform lints prior to macro expansion
... and 3 other queries... use `env RUST_BACKTRACE=1` to see the full query stack
warning: build failed, waiting for other jobs to finish...
[RUSTC-TIMING] core test:false 16.151
[RUSTC-TIMING] core test:false 16.151
Command has failed. Rerun with -v to see more details.
  local time: Mon Jan 27 02:31:30 UTC 2025
  network time: Mon, 27 Jan 2025 02:31:30 GMT
##[error]Process completed with exit code 1.
Post job cleanup.

@bors
Copy link
Contributor

bors commented Jan 27, 2025

💔 Test failed - checks-actions

@bors bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 27, 2025
@bors bors added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 27, 2025
@fmease
Copy link
Member

fmease commented Jan 27, 2025

@bors r-

@fmease fmease closed this Jan 27, 2025
@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 27, 2025
@jhpratt jhpratt deleted the rollup-p9wdze6 branch January 27, 2025 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-rustc-dev-guide Area: rustc-dev-guide rollup A PR which is a rollup S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants