Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rustc_codegen_gcc subtree #136024

Merged
merged 19 commits into from
Jan 27, 2025
Merged

Update rustc_codegen_gcc subtree #136024

merged 19 commits into from
Jan 27, 2025

Conversation

GuillaumeGomez
Copy link
Member

cc @antoyo

antoyo and others added 16 commits January 13, 2025 10:53
@antoyo
Merge commit '59a81c2ca1edc88ad3ac4b27a8e03977ffb8e73a' into subtree-…
43b7e28 
…update_cg_gcc_2025_01_12
@antoyo
Fix formatting
f8b89a3
@antoyo
Merge branch 'master' into sync_from_rust_2025_01_14
232d8a4
@antoyo
Merge pull request rust-lang#597 from rust-lang/sync_from_rust_2025_0…
f703358 
…1_14

Sync from rust 2025/01/14
@Sudhanshu069 @antoyo
Remove codegen_gcc_lto_not_supported in messages.flt
7bc6701
@antoyo
Update GCC version
50a9f41
@antoyo
Update the CI to Ubuntu 24.04
0ab1f8d
@antoyo
Merge pull request rust-lang#601 from rust-lang/update-gcc-2025-01-15
b5bc832 
Update GCC version
@Anon258
Add grep check for LTO Test
638611f
@antoyo
Merge pull request rust-lang#602 from Anon258/master
8037b61 
Add grep check for LTO Test
@GuillaumeGomez
Remove extra whitespace at the end of some line strings
8d0eb87
@antoyo
Merge pull request rust-lang#607 from GuillaumeGomez/cleanup
bbc5473 
Remove extra whitespace at the end of some line strings
@antoyo
Add comment to explain why CG_RUSTFLAGS is needed
f24b0d3
@GuillaumeGomez
Add --gcc-path option
4798615
@GuillaumeGomez
Add log to mention what GCC path the build script is using and where …
b8218f0 
…it comes from
@antoyo
Merge pull request rust-lang#608 from GuillaumeGomez/gcc-path
5491581 
Add `--gcc-path` option
@rustbot
Copy link
Collaborator

rustbot commented Jan 24, 2025

r? @BoxyUwU

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 24, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jan 24, 2025

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

@rustbot rustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 24, 2025
@GuillaumeGomez
Copy link
Member Author

r? @ghost

@rustbot
Copy link
Collaborator

rustbot commented Jan 24, 2025

Failed to set assignee to ghost: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

@GuillaumeGomez
Copy link
Member Author

@bors r+ rollup=never

@bors
Copy link
Contributor

bors commented Jan 24, 2025

📌 Commit dc0ccc6 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 24, 2025
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 24, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomez
Copy link
Member Author

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 24, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jan 24, 2025

There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

You can start a rebase with the following commands:

$ # rebase
$ git pull --rebase https://github.com/rust-lang/rust.git master
$ git push --force-with-lease

The following commits are merge commits:

@GuillaumeGomez
Copy link
Member Author

@bors r+ rollup=never

@bors
Copy link
Contributor

bors commented Jan 25, 2025

📌 Commit 7c177d5 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 25, 2025
@GuillaumeGomez
Copy link
Member Author

Increasing priority a bit...

@bors p=1

@bors
Copy link
Contributor

bors commented Jan 27, 2025

⌛ Testing commit 7c177d5 with merge f753850...

@bors
Copy link
Contributor

bors commented Jan 27, 2025

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing f753850 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 27, 2025
@bors bors merged commit f753850 into rust-lang:master Jan 27, 2025
7 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 27, 2025
@GuillaumeGomez GuillaumeGomez deleted the cg_gcc-subtree branch January 27, 2025 14:37
This was referenced Jan 27, 2025
Open
Open
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (f753850): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 0.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 3.0% [3.0%, 3.0%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -1.4% [-1.4%, -1.4%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.8% [-1.4%, 3.0%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 773.374s -> 773.18s (-0.03%)
Artifact size: 328.18 MiB -> 328.23 MiB (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoyo antoyo antoyo approved these changes

Assignees
No one assigned
Labels
has-merge-commits PR has merge commits, merge with caution. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.86.0
Development

Successfully merging this pull request may close these issues.
9 participants
@GuillaumeGomez @rustbot @bors @rust-log-analyzer @rust-timer @antoyo @BoxyUwU @Sudhanshu069 @Anon258