-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dev guide docs for error-pattern #135723
Conversation
I know it would have made more sense to make this PR to the dev guide repo but I had already made the fix before I realized that.
The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah thanks, I think I noticed this before but forgor about it.
@bors r+ rollup |
💀 |
…llaumeGomez Rollup of 5 pull requests Successful merges: - rust-lang#134858 (Provide structured suggestion for `#![feature(..)]` in more cases) - rust-lang#135679 (create an issue template for bootstrap) - rust-lang#135685 (Remove unused `item-row` CSS class) - rust-lang#135716 (Don't skip argument parsing when running `rustc` with no arguments) - rust-lang#135723 (Fix dev guide docs for error-pattern) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#135723 - Noratrieb:error-pattern-my-a-, r=jieyouxu Fix dev guide docs for error-pattern I know it would have made more sense to make this PR to the dev guide repo but I had already made the fix before I realized that. r? `@jieyouxu`
I know it would have made more sense to make this PR to the dev guide repo but I had already made the fix before I realized that.
r? @jieyouxu