Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow A { .. } if A has no fields #135703

Merged
merged 1 commit into from
Jan 19, 2025
Merged

Disallow A { .. } if A has no fields #135703

merged 1 commit into from
Jan 19, 2025

Conversation

estebank
Copy link
Contributor 

error: `A` has no fields, `..` needs at least one default field in the struct definition
  --> $DIR/empty-struct.rs:16:17
   |
LL |     let _ = A { .. };
   |             -   ^^
   |             |
   |             this type has no fields

@estebank
Disallow A { .. } if A has no fields
27f079a 
```
error: `A` has no fields, `..` needs at least one default field in the struct definition
  --> $DIR/empty-struct.rs:16:17
   |
LL |     let _ = A { .. };
   |             -   ^^
   |             |
   |             this type has no fields
```
@estebank estebank added the F-default_field_values `#![feature(default_field_values)]` label Jan 18, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jan 18, 2025

r? @wesleywiser

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 18, 2025
@estebank estebank mentioned this pull request Jan 18, 2025
Open
17 tasks
compiler-errors
compiler-errors approved these changes Jan 18, 2025
View reviewed changes
Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me when green

@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 18, 2025

📌 Commit 27f079a has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 18, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 19, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 19, 2025
@bors
Auto merge of rust-lang#135715 - matthiaskrgr:rollup-9a18sxj, r=matth…
9857284 
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#135641 ([rustdoc] Replace module list items `ul`/`li` with `dl`/`dd`/`dt` elements)
 - rust-lang#135703 (Disallow `A { .. }` if `A` has no fields)
 - rust-lang#135705 (Consolidate ad-hoc MIR lints into real pass-manager-based MIR lints)
 - rust-lang#135708 (Some random compiler nits)

Failed merges:

 - rust-lang#135685 (Remove unused `item-row` CSS class)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7e1ce54 into rust-lang:master Jan 19, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 19, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 19, 2025
@rust-timer
Unrolled build for rust-lang#135703
4658c97 
Rollup merge of rust-lang#135703 - estebank:empty-dfv, r=compiler-errors

Disallow `A { .. }` if `A` has no fields

```
error: `A` has no fields, `..` needs at least one default field in the struct definition
  --> $DIR/empty-struct.rs:16:17
   |
LL |     let _ = A { .. };
   |             -   ^^
   |             |
   |             this type has no fields
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors approved these changes

Assignees

@compiler-errors compiler-errors

Labels
F-default_field_values `#![feature(default_field_values)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.86.0
Development

Successfully merging this pull request may close these issues.
5 participants
@estebank @rustbot @compiler-errors @bors @wesleywiser