-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cfg(debug_assertions) to CurrentDepGraph debug fields #135449
Conversation
I'm missing context for this, so r? incremental |
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
…ssert, r=<try> Add cfg(debug_assertions) to CurrentDepGraph debug fields The change cascades down to the use sites of the fields. After the change then `dep_graph::serialized::Stat.kind` is dead code in non-debug builds, and it turns out it can be removed entirely, since its value can be read from a HashMap key at the only use site of the field.
Is |
not without debug assertions |
Then this pr breaks nightly flag. Wrong cfg's or this was intended? |
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
a4ef424
to
ff296f4
Compare
Unintended, thanks. Updated the PR so |
Won’t there be no data without debug assertions? |
For the total edge reads and total duplicate edge reads, yes, but those fields are currently also only written to (and printed) when |
Finished benchmarking commit (12a17c2): comparison URL. Overall result: no relevant changes - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (secondary 1.6%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary 6.7%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 763.215s -> 764.132s (0.12%) |
☔ The latest upstream changes (presumably #136471) made this pull request unmergeable. Please resolve the merge conflicts. |
The change cascades down to the use sites of the fields.
After the change then
dep_graph::serialized::Stat.kind
isdead code in non-debug builds, and it turns out it can be removed
entirely, since its value can be read from a HashMap key at the
only use site of the field.