Clippy subtree update #135297

flip1995 · 2025-01-09T18:33:39Z

`is_integer_const()` does the const folding.

…sing_errors_doc`

…ubtree-update

Handle field attributes in suggestions Fix adjacent code Address review comments rust-lang/rust-clippy#13737 (comment) Address all review comments but one This comment is not yet addressed: rust-lang/rust-clippy#13737 (comment) `initializer_suggestions` -> `lint_inconsistent_struct_field_initializers`

`is_integer_const()` does the const folding. changelog: none

fix rust-lang#13843 The `manual_div_ceil` lint makes incorrect suggestion when type suffixes need to be made explicit in the suggested code. changelog: [`manual_div_ceil`]: suggested code now includes appropriate type suffixes where necessary

…lready been resolved (rust-lang#13873) The "known problems" pointed out in the `match_same_arms` lint seem to have already been resolved. changelog: none

@samueltardieu

…uirement configurable (rust-lang#13737) Fixes rust-lang#11846. This PR has three commits: - The first commit adds an `initializer-suggestions` configuration to control suggestion applicability when initializers are present. The following are the options: - "none": do not suggest - "maybe-incorrect": suggest, but do not apply suggestions with `--fix` - "machine-applicable": suggest and apply suggestions with `--fix` - The second commit fixes suggestions to handle field attributes (problem [noticed by @samueltardieu](rust-lang/rust-clippy#13737 (comment))). - The third commit adds `initializer-suggestions = "machine-applicable"` to Clippy's `clippy.toml` and applies the suggestions. (Nothing seems to break.) --- changelog: make `inconsistent_struct_constructor` "all fields are shorthand" requirement configurable

changelog: none

…ntinue`, recursively fixes: rust-lang#4077

Convert the ICE reported in rust-lang#12979 into a false negative. We prefer a false negative to a ICE (because the ICE could still affect the user even when not activating the lint).

Close rust-lang#13837 changelog: [`trailing_empty_array`]: do not trigger on tests

Examples fixes for regex changelog: none

…ang#13863) Fixes rust-lang#13862 `missing_headers::check` is sometimes called from outside of a body (specifically, from `check_attributes`, where the LateContext's ParamEnv is not yet properly initialized for that item). Using that empty ParamEnv for trait solving things from within the body can then lead to various ICEs, like the linked issue where we have a const generic parameter `DMA_INST` without a `ConstArgHasType` bound in the ParamEnv so the const parameter has no type, which is normally not supposed to happen. We have the item's DefId so we can just get its ParamEnv/TypingEnv from there, and using that one for trait solving should be safe. changelog: none

Also, simplify boolean expression, and ensure that proper applicability is used.

This PR just makes sure that we exit the function before getting an ICE and adds a regression test. Related to rust-lang#12979. We would need to keep researching the issue, but as the ICEing code isn't that complicated, getting a hotfix into nightly is urgent. changelog:[`borrow_interior_mutable_const`] Fix ICE rust-lang#12979

…t-lang#13884) Also, simplify boolean shortcut expression, and ensure that applicability is properly applied, as it was ignored and `MachineApplicable` was always used. changelog: [`borrow_as_ptr`]: do not remove required parentheses in autofix suggestion Close rust-lang#13882

Removing `.map(identity)` may result in invalid code if the receiver of `map()` is an immutable binding, and the result of `map()` is used as the receiver of a method call expecting a mutable reference.

Using `lifetime.ident.name` in suggestions will not output the raw modifier. For example, `'r#struct` will be rendered as `'struct` which would be incorrect.

@y21

I discovered that there were paths declared in `clippy_utils::paths` in rust-lang/rust-clippy#13829 so moving a few remaining hardcoded ones in one place. changelog: Move more def paths into `clippy_utils::paths` r? @y21

…ust-lang#13906) Proper parentheses need to be added to some expressions in receiver position. Fix rust-lang#13902 changelog: [`redundant_pattern_matching`]: use proper parentheses when suggesting replacing `matches!(…, None)` by `.is_none()`

Using `lifetime.ident.name` in suggestions will not output the raw modifier. For example, `'r#struct` will be rendered as `'struct` which would be incorrect. Fix rust-lang#13899 changelog: [`needless_arbitrary_self_type`]: use the raw lifetime name in suggestions

@ghost

r? @ghost changelog: none

…ubtree-update

rustbot · 2025-01-09T18:33:50Z

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

flip1995 · 2025-01-09T18:34:09Z

Cargo.lock update is for bumping the Clippy version.

matthiaskrgr · 2025-01-09T18:38:14Z

@bors r+ p=5

bors · 2025-01-09T18:38:18Z

📌 Commit 43c3b30 has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2025-01-09T19:07:26Z

⌛ Testing commit 43c3b30 with merge af01afb...

…tthiaskrgr Clippy subtree update r? `@Manishearth`

rust-log-analyzer · 2025-01-09T19:13:45Z

The job x86_64-rust-for-linux failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

curl: (22) The requested URL returned error: 404
curl: (22) The requested URL returned error: 404
ERROR: failed to download llvm from ci

    HELP: There could be two reasons behind this:
        1) The host triple is not supported for `download-ci-llvm`.
        2) Old builds get deleted after a certain time.
    HELP: In either case, disable `download-ci-llvm` in your config.toml:
    [llvm]
    download-ci-llvm = false
    
Build completed unsuccessfully in 0:00:23

bors · 2025-01-09T19:14:03Z

💔 Test failed - checks-actions

matthiaskrgr · 2025-01-09T19:39:47Z

@bors retry

tgross35 · 2025-01-10T03:09:21Z

I guess bors doesn't respond to treeclosed on closed PRs so stealing this one

@bors treeclosed-

bors · 2025-01-10T03:10:32Z

⌛ Testing commit 43c3b30 with merge 88ab2d8...

bors · 2025-01-10T06:03:57Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 88ab2d8 to master...

rust-timer · 2025-01-10T07:21:09Z

Finished benchmarking commit (88ab2d8): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.5%	[-1.5%, -1.5%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (secondary -0.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.0%	[3.0%, 3.0%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.9%	[-3.9%, -3.9%]	1
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 763.867s -> 762.519s (-0.18%)
Artifact size: 325.73 MiB -> 325.74 MiB (0.00%)

alex-semenyuk and others added 30 commits December 17, 2024 14:16

Do not trigger trailing_empty_array in tests

a5d5edc

Remove obsolete comment

639f405

`is_integer_const()` does the const folding.

use the correct ParamEnv when checking future's return type in `mis…

15ab2ff

…sing_errors_doc`

correct suggestion for manual_div_ceil lint

de86302

remove known problems section from match_same_arms

71f1a87

Examples fixes for regex

be09596

Merge commit '609cd310be44677ae31d452a17b0f8207e1abfe1' into clippy-s…

1cc5051

…ubtree-update

Remove obsolete comment (rust-lang#13850)

553a381

`is_integer_const()` does the const folding. changelog: none

remove description of known problems in match_same_arms that have a…

363e61d

…lready been resolved (rust-lang#13873) The "known problems" pointed out in the `match_same_arms` lint seem to have already been resolved. changelog: none

fix arguments of ExprKind::MethodCall

09022bb

fix arguments of ExprKind::MethodCall (rust-lang#13890)

998c780

changelog: none

[needless_continue]: lint if the last stmt in for/while/loop is `co…

e582fcd

…ntinue`, recursively fixes: rust-lang#4077

borrow_interior_mutable_const ICE into FN

d7cc6c4

Convert the ICE reported in rust-lang#12979 into a false negative. We prefer a false negative to a ICE (because the ICE could still affect the user even when not activating the lint).

Do not trigger trailing_empty_array in tests (rust-lang#13844)

786f090

Close rust-lang#13837 changelog: [`trailing_empty_array`]: do not trigger on tests

Examples fixes for regex (rust-lang#13874)

aef4772

Examples fixes for regex changelog: none

Do not remove required parentheses in borrow_as_ptr suggestion

eef47fc

Also, simplify boolean expression, and ensure that proper applicability is used.

Move more def paths into clippy_utils::paths

34b1765

Do not remove identity mapping if mandatory mutability would be lost

a9fe043

Removing `.map(identity)` may result in invalid code if the receiver of `map()` is an immutable binding, and the result of `map()` is used as the receiver of a method call expecting a mutable reference.

Fix parentheses when replacing matches!(…, None) with .is_none()

e4b11a7

Use the full lifetime name in suggestions

a657fcc

Using `lifetime.ident.name` in suggestions will not output the raw modifier. For example, `'r#struct` will be rendered as `'struct` which would be incorrect.

Correctly handle char paths

b515064

Move more def paths into clippy_utils::paths (rust-lang#13903)

be49f86

I discovered that there were paths declared in `clippy_utils::paths` in rust-lang/rust-clippy#13829 so moving a few remaining hardcoded ones in one place. changelog: Move more def paths into `clippy_utils::paths` r? @y21

flip1995 added 4 commits January 9, 2025 18:01

Bump Clippy version -> 0.1.86

663892b

Rustup (rust-lang#13970)

19e305b

r? @ghost changelog: none

Merge commit '19e305bb57a7595f2a8d81f521c0dd8bf854e739' into clippy-s…

573db1c

…ubtree-update

Update Cargo.lock

43c3b30

rustbot assigned Manishearth Jan 9, 2025

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 9, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 9, 2025

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 9, 2025

Auto merge of rust-lang#135297 - flip1995:clippy-subtree-update, r=ma…

af01afb

…tthiaskrgr Clippy subtree update r? `@Manishearth`

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 9, 2025

matthiaskrgr mentioned this pull request Jan 9, 2025

Unify conditional-const error reporting with non-const error reporting #134732

Merged

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 9, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 10, 2025

bors merged commit 88ab2d8 into rust-lang:master Jan 10, 2025
7 checks passed

rustbot added this to the 1.86.0 milestone Jan 10, 2025

flip1995 deleted the clippy-subtree-update branch January 10, 2025 09:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clippy subtree update #135297

Clippy subtree update #135297

flip1995 commented Jan 9, 2025

rustbot commented Jan 9, 2025

flip1995 commented Jan 9, 2025

matthiaskrgr commented Jan 9, 2025

bors commented Jan 9, 2025

bors commented Jan 9, 2025

rust-log-analyzer commented Jan 9, 2025

bors commented Jan 9, 2025

matthiaskrgr commented Jan 9, 2025

tgross35 commented Jan 10, 2025

bors commented Jan 10, 2025

bors commented Jan 10, 2025

rust-timer commented Jan 10, 2025

Clippy subtree update #135297

Clippy subtree update #135297

Conversation

flip1995 commented Jan 9, 2025

rustbot commented Jan 9, 2025

flip1995 commented Jan 9, 2025

matthiaskrgr commented Jan 9, 2025

bors commented Jan 9, 2025

bors commented Jan 9, 2025

rust-log-analyzer commented Jan 9, 2025

bors commented Jan 9, 2025

matthiaskrgr commented Jan 9, 2025

tgross35 commented Jan 10, 2025

bors commented Jan 10, 2025

bors commented Jan 10, 2025

rust-timer commented Jan 10, 2025

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size