Make it easier to run CI jobs locally #134898
Merged
+229
−112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a7b5acf to
c2172a9
Compare
the8472
reviewed
Dec 29, 2024
|
(if this lands, https://rustc-dev-guide.rust-lang.org/tests/docker.html#testing-with-docker will also need to be updated) |
c2172a9 to
bdbf783
Compare
This comment has been minimized.
This comment has been minimized.
bdbf783 to
0021c22
Compare
jieyouxu
approved these changes
Dec 31, 2024
|
The changes LGTM, but I'm not an infra reviewer, so r? infra |
This comment has been minimized.
This comment has been minimized.
c017f3f to
28105d9
Compare
MarcoIeni
reviewed
Jan 7, 2025
The `image` part didn't really make sense, especially since we started splitting CI jobs.
28105d9 to
9d015ed
Compare
|
The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes. |
|
Rebased, applied review comments and also updated rustc-dev-guide. |
This comment has been minimized.
This comment has been minimized.
2f63bbe to
65819b1
Compare
|
Sorry for the delay, I lost the GitHub notification somehow! @bors r+ |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 9, 2025
…iaskrgr Rollup of 3 pull requests Successful merges: - rust-lang#134898 (Make it easier to run CI jobs locally) - rust-lang#135195 (Make `lit_to_mir_constant` and `lit_to_const` infallible) - rust-lang#135261 (Account for identity substituted items in symbol mangling) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 9, 2025
…iaskrgr Rollup of 3 pull requests Successful merges: - rust-lang#134898 (Make it easier to run CI jobs locally) - rust-lang#135195 (Make `lit_to_mir_constant` and `lit_to_const` infallible) - rust-lang#135261 (Account for identity substituted items in symbol mangling) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 9, 2025
Rollup merge of rust-lang#134898 - Kobzol:ci-python-script, r=MarcoIeni Make it easier to run CI jobs locally This PR extends the Python CI script to perform a poor man's CI-like execution of a given CI job locally. It's not perfect, but it's better than nothing. r? `@jieyouxu`
|
Note to myself: next time we should mark CI affecting PRs with rollup=never :) |
Merged
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 10, 2025
CI: fix name of jobs There is a difference between the `image` (the Dockerfile), the `name` of the job (which determines also its properties) and the `full_name`, which includes the `auto/try/pr` prefix. Missed this in rust-lang#134898.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the Python CI script to perform a poor man's CI-like execution of a given CI job locally. It's not perfect, but it's better than nothing.
r? @jieyouxu