Implement int_from_ascii (#134821)

[niklasf]

Provides unstable T::from_ascii() and T::from_ascii_radix() for integer types T, as drafted in tracking issue #134821.

To deduplicate documentation without additional macros, implementations of isize and usize no longer delegate to equivalent integer types. After #132870 they are inlined anyway.

[rustbot]

r? @ibraheemdev

rustbot has assigned @ibraheemdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[ibraheemdev]

This looks good. Just to make sure that the explicit inlining doesn't affect anything
@bors try @rust-timer queue

[bors]

⌛ Trying commit 7d0518c with merge 8ac1775...

[bors]

☀️ Try build successful - checks-actions
Build commit: 8ac1775 (8ac17751217e45558eed8ba57f1cc4944b85e166)

[rust-timer]

Finished benchmarking commit (8ac1775): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.7%	[0.7%, 0.7%]	1
Regressions ❌ (secondary)	0.2%	[0.2%, 0.2%]	4
Improvements ✅ (primary)	-0.4%	[-0.4%, -0.4%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.2%	[-0.4%, 0.7%]	2

Max RSS (memory usage)

Results (primary 0.5%, secondary -1.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	4.7%	[4.1%, 5.4%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.7%	[-4.6%, -2.7%]	2
Improvements ✅ (secondary)	-1.7%	[-1.7%, -1.7%]	1
All ❌✅ (primary)	0.5%	[-4.6%, 5.4%]	4

Cycles

Results (primary 0.9%, secondary 3.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.9%	[0.9%, 0.9%]	1
Regressions ❌ (secondary)	9.8%	[9.8%, 9.8%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.3%	[-2.3%, -2.3%]	1
All ❌✅ (primary)	0.9%	[0.9%, 0.9%]	1

Binary size

Results (primary 0.0%, secondary 0.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.0%, 0.2%]	13
Regressions ❌ (secondary)	0.1%	[0.1%, 0.1%]	38
Improvements ✅ (primary)	-0.0%	[-0.1%, -0.0%]	10
Improvements ✅ (secondary)	-0.0%	[-0.0%, -0.0%]	4
All ❌✅ (primary)	0.0%	[-0.1%, 0.2%]	23

Bootstrap: 762.718s -> 763.43s (0.09%)
Artifact size: 326.06 MiB -> 326.13 MiB (0.02%)

[niklasf]

Asked for advice in Zulip. Small regression expected due to extra methods (with docs).

@rustbot label: +perf-regression-triaged

[ibraheemdev]

Yeah this looks good to me. Thanks! @bors r+

[bors]

📌 Commit 7d0518c has been approved by ibraheemdev

It is now in the queue for this repository.

[matthiaskrgr]

@bors p=5 (scheduling)

[bors]

⌛ Testing commit 7d0518c with merge e506248...

[tgross35]

@bors r- retry

Job looks stuck

[tgross35]

@bors retry

[tgross35]

@bors r=ibraheemdev

[bors]

📌 Commit 7d0518c has been approved by ibraheemdev

It is now in the queue for this repository.

[bors]

⌛ Testing commit 7d0518c with merge a6434ef...

[bors]

☀️ Test successful - checks-actions
Approved by: ibraheemdev
Pushing a6434ef to master...

[rust-timer]

Finished benchmarking commit (a6434ef): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.9%	[0.9%, 0.9%]	1
Regressions ❌ (secondary)	0.3%	[0.3%, 0.3%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.3%	[-0.3%, -0.3%]	1
All ❌✅ (primary)	0.9%	[0.9%, 0.9%]	1

Max RSS (memory usage)

Results (primary -0.5%, secondary -1.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	4.7%	[2.7%, 8.5%]	3
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.8%	[-4.4%, -0.9%]	7
Improvements ✅ (secondary)	-1.8%	[-3.1%, -1.1%]	3
All ❌✅ (primary)	-0.5%	[-4.4%, 8.5%]	10

Cycles

Results (primary 1.6%, secondary -1.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.6%	[1.6%, 1.6%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.9%	[-1.9%, -1.9%]	1
All ❌✅ (primary)	1.6%	[1.6%, 1.6%]	1

Binary size

Results (primary 0.0%, secondary 0.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.0%, 0.1%]	14
Regressions ❌ (secondary)	0.1%	[0.1%, 0.1%]	38
Improvements ✅ (primary)	-0.1%	[-0.1%, -0.0%]	6
Improvements ✅ (secondary)	-0.0%	[-0.0%, -0.0%]	4
All ❌✅ (primary)	0.0%	[-0.1%, 0.1%]	20

Bootstrap: 778.535s -> 778.54s (0.00%)
Artifact size: 328.51 MiB -> 328.55 MiB (0.01%)