Windows: remove readonly files #134679

ChrisDenton · 2024-12-23T07:30:28Z

When calling remove_file, we shouldn't fail to delete readonly files. As the test makes clear, this make the Windows behaviour consistent with other platforms. This also makes us internally consistent with remove_dir_all.

try-job: x86_64-msvc-ext1

rustbot · 2024-12-23T07:30:36Z

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

tbu- · 2024-12-26T01:42:28Z

Could you add that to the platform-specific behavior section of fs::remove?

ChrisDenton · 2024-12-26T10:43:46Z

I've added a note about which functions are used.

Mark-Simulacrum

Do we need libs/libs-api FCP of some kind given the new (at least implicit) guarantee? The impl seems fine but I don't have the Windows knowledge to thoroughly check it.

Mark-Simulacrum · 2024-12-27T00:03:22Z

library/std/src/sys/pal/windows/fs.rs

+            let mut opts = OpenOptions::new();
+            opts.access_mode(c::DELETE);
+            opts.custom_flags(c::FILE_FLAG_OPEN_REPARSE_POINT);
+            if File::open_native(&p_u16s, &opts).map(|f| f.posix_delete()).is_ok() {


Could this cause concurrent deletes of the same file to fail due to having an open handle (iirc windows doesn't let you delete files with open handles?)? I guess before it would also fail with the same error, so not sure that matters even if true...

DeleteFile does also open the file in a similar way to we're doing so there's actually no change there.

iirc windows doesn't let you delete files with open handles

That's not quite right. When opening files there's a "sharing mode" that lets you allow others to open the same file. One of those modes is FILE_SHARE_DELETE. If someone opens a file without that share mode then it will prevent any deletions no matter what we do.

Deletes can also race with each other because there's a time between marking a file for deletion and closing the handle where the file is in a kind of limbo state. It can't be opened but it still exists on the filesystem.

But either case is the same whether we use DeleteFile or open the file ourselves.

I see, sounds good. Thanks for clarifying! :)

ChrisDenton · 2024-12-27T00:26:09Z

Do we need libs/libs-api FCP of some kind given the new (at least implicit) guarantee

I'll add a label to see if libs-api want to discuss it. This aligns the behaviour with other platforms so I think it's worthwhile.

ChrisDenton · 2024-12-27T17:22:04Z

Oh, I should write a summary of the question being asked of libs-api

@rust-lang/libs-api on platforms except Windows, read-only files are deleted when calling remove_file. On Windows support for doing this was only added relatively recently and is not done by the normal DeleteFile function.

This PR changes remove_file so that it will delete read-only files if possible. It does this by reusing code we already use in remove_dir_all.

Does this new (for Windows) behaviour require a libs-api FCP?

dtolnay · 2024-12-27T17:38:10Z

@rustbot ping windows
See summary in the previous comment. Please point out if there is some reason this wouldn't be desirable.

rustbot · 2024-12-27T17:38:12Z

Hey Windows Group! This bug has been identified as a good "Windows candidate".
In case it's useful, here are some instructions for tackling these sorts of
bugs. Maybe take a look?
Thanks! <3

cc @albertlarsan68 @arlosi @ChrisDenton @danielframpton @gdr-at-ms @kennykerr @luqmana @lzybkr @nico-abram @retep998 @sivadeilra @wesleywiser

dtolnay · 2024-12-27T17:38:27Z

@rfcbot fcp merge

rfcbot · 2024-12-27T17:38:56Z

Team member @dtolnay has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

rfcbot · 2025-01-14T16:49:52Z

🔔 This is now entering its final comment period, as per the review above. 🔔

rfcbot · 2025-01-24T16:50:41Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

ChrisDenton · 2025-01-24T21:24:12Z

The libs-api team discussed this, the RFC is now complete and Mark said the implementation looked fine so...

@bors r=Mark-Simulacrum

bors · 2025-01-24T21:24:15Z

📌 Commit 6ffc9ca has been approved by Mark-Simulacrum

It is now in the queue for this repository.

matthiaskrgr · 2025-01-25T22:46:31Z

@bors try

Windows: remove readonly files When calling `remove_file`, we shouldn't fail to delete readonly files. As the test makes clear, this make the Windows behaviour consistent with other platforms. This also makes us internally consistent with `remove_dir_all`. try-job: x86_64-msvc-ext1

bors · 2025-01-25T22:47:46Z

⌛ Trying commit 6ffc9ca with merge 358a624...

bors · 2025-01-26T00:46:11Z

💔 Test failed - checks-actions

ChrisDenton · 2025-01-26T06:06:45Z

That looks like a genuine failure, I'll fix.

ChrisDenton · 2025-01-26T06:23:02Z

I added a rust integration test that asserts deleting a running binary fails on Windows. I made it an integration test because one "failure" mode would be to somehow actually delete the running binary and I wasn't sure that would be a good idea for unit tests. An alternative would be a full blown run-make test that compiles a separate executable to run and delete but that seemed like overkill for this.

@rustbot ready

Mark-Simulacrum · 2025-02-08T15:01:11Z

@bors r+

bors · 2025-02-08T15:01:14Z

📌 Commit 962ebf0 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

…mulacrum Windows: remove readonly files When calling `remove_file`, we shouldn't fail to delete readonly files. As the test makes clear, this make the Windows behaviour consistent with other platforms. This also makes us internally consistent with `remove_dir_all`. try-job: x86_64-msvc-ext1

Rollup of 5 pull requests Successful merges: - rust-lang#134679 (Windows: remove readonly files) - rust-lang#136213 (Allow Rust to use a number of libc filesystem calls) - rust-lang#136530 (Implement `x perf` directly in bootstrap) - rust-lang#136601 (Detect (non-raw) borrows of null ZST pointers in CheckNull) - rust-lang#136659 (Pick the max DWARF version when LTO'ing modules with different versions ) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#134679 - ChrisDenton:rm-readonly, r=Mark-Simulacrum Windows: remove readonly files When calling `remove_file`, we shouldn't fail to delete readonly files. As the test makes clear, this make the Windows behaviour consistent with other platforms. This also makes us internally consistent with `remove_dir_all`. try-job: x86_64-msvc-ext1

…oratrieb ignore win_delete_self test in Miri Follow-up to rust-lang#134679, fixes miri-test-libstd on Windows Cc `@ChrisDenton` `@Mark-Simulacrum`

Rollup merge of rust-lang#136805 - RalfJung:miri-win-delete-self, r=Noratrieb ignore win_delete_self test in Miri Follow-up to rust-lang#134679, fixes miri-test-libstd on Windows Cc `@ChrisDenton` `@Mark-Simulacrum`

rustbot assigned Mark-Simulacrum Dec 23, 2024

rustbot added O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 23, 2024

Mark-Simulacrum reviewed Dec 27, 2024

View reviewed changes

rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Dec 27, 2024

Amanieu removed the S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). label Jan 14, 2025

rfcbot added the final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. label Jan 14, 2025

rfcbot removed the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Jan 14, 2025

rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Jan 24, 2025

rfcbot added the to-announce Announce this issue on triage meeting label Jan 24, 2025

rustbot mentioned this pull request Jan 24, 2025

Tracking issue for release notes of #134679: Windows: remove readonly files #136008

Open

3 tasks

This comment has been minimized.

Sign in to view

ChrisDenton added 2 commits January 26, 2025 05:42

Windows: remove readonly files

457e528

Update platform information for remove_file

50522fa

Windows: Test that deleting a running binary fails

962ebf0

ChrisDenton force-pushed the rm-readonly branch from 6ffc9ca to 962ebf0 Compare January 26, 2025 06:17

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 26, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 8, 2025

This was referenced Feb 8, 2025

Rollup of 6 pull requests #136753

Closed

Rollup of 5 pull requests #136754

Merged

bors merged commit 3418247 into rust-lang:master Feb 9, 2025
6 checks passed

rustbot added this to the 1.86.0 milestone Feb 9, 2025

ChrisDenton deleted the rm-readonly branch February 9, 2025 17:34

RalfJung mentioned this pull request Feb 10, 2025

ignore win_delete_self test in Miri #136805

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Windows: remove readonly files #134679

Windows: remove readonly files #134679

ChrisDenton commented Dec 23, 2024 •

edited by matthiaskrgr

Loading

rustbot commented Dec 23, 2024

tbu- commented Dec 26, 2024

ChrisDenton commented Dec 26, 2024

Mark-Simulacrum left a comment

Mark-Simulacrum Dec 27, 2024

ChrisDenton Dec 27, 2024

Mark-Simulacrum Dec 27, 2024

ChrisDenton commented Dec 27, 2024

ChrisDenton commented Dec 27, 2024

dtolnay commented Dec 27, 2024

rustbot commented Dec 27, 2024

dtolnay commented Dec 27, 2024

rfcbot commented Dec 27, 2024 •

edited by Amanieu

Loading

rfcbot commented Jan 14, 2025

rfcbot commented Jan 24, 2025

ChrisDenton commented Jan 24, 2025

bors commented Jan 24, 2025

matthiaskrgr commented Jan 25, 2025

bors commented Jan 25, 2025

This comment has been minimized.

bors commented Jan 26, 2025

ChrisDenton commented Jan 26, 2025

ChrisDenton commented Jan 26, 2025

Mark-Simulacrum commented Feb 8, 2025

bors commented Feb 8, 2025

Windows: remove readonly files #134679

Windows: remove readonly files #134679

Conversation

ChrisDenton commented Dec 23, 2024 • edited by matthiaskrgr Loading

rustbot commented Dec 23, 2024

tbu- commented Dec 26, 2024

ChrisDenton commented Dec 26, 2024

Mark-Simulacrum left a comment

Choose a reason for hiding this comment

Mark-Simulacrum Dec 27, 2024

Choose a reason for hiding this comment

ChrisDenton Dec 27, 2024

Choose a reason for hiding this comment

Mark-Simulacrum Dec 27, 2024

Choose a reason for hiding this comment

ChrisDenton commented Dec 27, 2024

ChrisDenton commented Dec 27, 2024

dtolnay commented Dec 27, 2024

rustbot commented Dec 27, 2024

dtolnay commented Dec 27, 2024

rfcbot commented Dec 27, 2024 • edited by Amanieu Loading

rfcbot commented Jan 14, 2025

rfcbot commented Jan 24, 2025

ChrisDenton commented Jan 24, 2025

bors commented Jan 24, 2025

matthiaskrgr commented Jan 25, 2025

bors commented Jan 25, 2025

This comment has been minimized.

bors commented Jan 26, 2025

ChrisDenton commented Jan 26, 2025

ChrisDenton commented Jan 26, 2025

Mark-Simulacrum commented Feb 8, 2025

bors commented Feb 8, 2025

ChrisDenton commented Dec 23, 2024 •

edited by matthiaskrgr

Loading

rfcbot commented Dec 27, 2024 •

edited by Amanieu

Loading