Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add member constraints comment #134553

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Dec 20, 2024

r? @oli-obk i guess

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 20, 2024
@oli-obk
Copy link
Contributor

oli-obk commented Dec 20, 2024

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 20, 2024

📌 Commit 33269e1 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 20, 2024
@rust-log-analyzer

This comment has been minimized.

@Noratrieb
Copy link
Member

@bors r- no

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 20, 2024
@lcnr
Copy link
Contributor Author

lcnr commented Dec 20, 2024

nyaaaaaaaaaaaaaaaaaaa

@lcnr lcnr force-pushed the member-constraints-comment branch from 33269e1 to adf5498 Compare December 20, 2024 12:09
@lcnr
Copy link
Contributor Author

lcnr commented Dec 20, 2024

@bors r=oli-obk

@bors
Copy link
Contributor

bors commented Dec 20, 2024

📌 Commit adf5498 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 20, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 20, 2024
Rollup of 5 pull requests

Successful merges:

 - rust-lang#134366 (Fix logical error with what text is considered whitespace.)
 - rust-lang#134514 (Improve dependency_format a bit)
 - rust-lang#134519 (ci: use ubuntu `24` instead of `latest`)
 - rust-lang#134551 (coverage: Rename `basic_coverage_blocks` to just `graph`)
 - rust-lang#134553 (add member constraints comment)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 20, 2024
Rollup of 5 pull requests

Successful merges:

 - rust-lang#134366 (Fix logical error with what text is considered whitespace.)
 - rust-lang#134514 (Improve dependency_format a bit)
 - rust-lang#134519 (ci: use ubuntu `24` instead of `latest`)
 - rust-lang#134551 (coverage: Rename `basic_coverage_blocks` to just `graph`)
 - rust-lang#134553 (add member constraints comment)

r? `@ghost`
`@rustbot` modify labels: rollup
@Noratrieb
Copy link
Member

gamer

jieyouxu added a commit to jieyouxu/rust that referenced this pull request Dec 20, 2024
…=oli-obk

add member constraints comment

r? `@oli-obk` i guess
@bors bors merged commit 594e74d into rust-lang:master Dec 20, 2024
6 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Dec 20, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 20, 2024
Rollup merge of rust-lang#134553 - lcnr:member-constraints-comment, r=oli-obk

add member constraints comment

r? `@oli-obk` i guess
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants