cleanup promoteds move check #134455
Merged
cleanup promoteds move check #134455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4f94860 to
f936122
Compare
compiler-errors
requested changes
Dec 18, 2024
compiler/rustc_borrowck/src/lib.rs
Outdated
| let promoted_body = &promoted[idx]; | ||
| // FIXME: This assumes that we don't try to access most fields of the `promoted_mbcx`. | ||
| // We may want to move `MoveError` construction and reporting out of `MirBorrowckCtxt`. | ||
| let move_data = MoveData::gather_moves(body, tcx, |_| true); |
There was a problem hiding this comment.
shouldn't this be promoted_body?
Suggested change
| let move_data = MoveData::gather_moves(body, tcx, |_| true); | |
| let move_data = MoveData::gather_moves(promoted_body, tcx, |_| true); |
There was a problem hiding this comment.
If so, then we probably need a test that actually exercises this, because the fact that this didn't fail makes me very nervous lol
There was a problem hiding this comment.
oh wow, yeah, that's... interesting
There was a problem hiding this comment.
from what I can tell the answer is: yes, iut should clearly be promoted_body and also: it is entirely unused by check_movable_place which is very gamer
There was a problem hiding this comment.
gonna do the refactor from my fixme i guess, because that's sus
// FIXME: This assumes that we don't try to access most fields of the `promoted_mbcx`.
// We may want to move `MoveError` construction and reporting out of `MirBorrowckCtxt`.
|
r? compiler-errors |
f936122 to
fc9a14d
Compare
|
@rustbot ready
Moving this error reporting out of the |
|
@bors r+ |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 17, 2025
…ompiler-errors cleanup promoteds move check r? types
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 17, 2025
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#134455 (cleanup promoteds move check) - rust-lang#135421 (Make tidy warn on unrecognized directives) - rust-lang#135611 (Remove unnecessary assertion for reference error) - rust-lang#135620 (ci: improve github action name) - rust-lang#135621 (Move some std tests to integration tests) - rust-lang#135639 (new solver: prefer trivial builtin impls) - rust-lang#135654 (add src/librustdoc and src/rustdoc-json-types to RUSTC_IF_UNCHANGED_ALLOWED_PATHS) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 18, 2025
…piler-errors cleanup promoteds move check r? types
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
|
@bors retry fuchsia not working |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 18, 2025
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#134455 (cleanup promoteds move check) - rust-lang#135421 (Make tidy warn on unrecognized directives) - rust-lang#135611 (Remove unnecessary assertion for reference error) - rust-lang#135620 (ci: improve github action name) - rust-lang#135639 (new solver: prefer trivial builtin impls) - rust-lang#135654 (add src/librustdoc and src/rustdoc-json-types to RUSTC_IF_UNCHANGED_ALLOWED_PATHS) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 18, 2025
Rollup merge of rust-lang#134455 - lcnr:move-errors-in-promoteds, r=compiler-errors cleanup promoteds move check r? types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? types