Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtree update of rust-analyzer #133564

Merged
merged 27 commits into from
Nov 28, 2024
Merged

Subtree update of rust-analyzer #133564

merged 27 commits into from
Nov 28, 2024

Conversation

lnicola
Copy link
Member

@lnicola lnicola commented Nov 28, 2024

r? @ghost

Giga-Bowser and others added 26 commits November 1, 2024 12:35
Signed-off-by: Tarek <tareknaser360@gmail.com>
feat: Use snippet placeholders for generated match arms
…espace_in_merge_match_arms

Improve selection handling for the `merge_match_arms` assist
…rder_impl_items

Migrate `reorder_impl_items` Assist to Use `SyntaxFactory`
…_braces-to-use-SyntaxFactory

feat: convert add_braces to SyntaxFactory SyntaxEditor abstraction
Update file path for request.rs entry point in architecture.md
internal: Fix missing `rust-src` message
fix: Fix a stack overflow when computing the sizedness of a struct that includes itself as the tail field
Re-add `rust-analyzer.cargo.sysrootQueryMetadata`
@rustbot
Copy link
Collaborator

rustbot commented Nov 28, 2024

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 28, 2024
@lnicola
Copy link
Member Author

lnicola commented Nov 28, 2024

@bors r+ p=1 subtree update

@bors
Copy link
Contributor

bors commented Nov 28, 2024

📌 Commit 8cf30c2 has been approved by lnicola

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 28, 2024
@rust-log-analyzer

This comment has been minimized.

@lnicola
Copy link
Member Author

lnicola commented Nov 28, 2024

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 28, 2024
@lnicola
Copy link
Member Author

lnicola commented Nov 28, 2024

@bors r+ p=1 subtree update

@bors
Copy link
Contributor

bors commented Nov 28, 2024

📌 Commit 15e8a26 has been approved by lnicola

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 28, 2024
@bors
Copy link
Contributor

bors commented Nov 28, 2024

⌛ Testing commit 15e8a26 with merge c1cfab2...

@bors
Copy link
Contributor

bors commented Nov 28, 2024

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing c1cfab2 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 28, 2024
@bors bors merged commit c1cfab2 into rust-lang:master Nov 28, 2024
7 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Nov 28, 2024
@lnicola lnicola deleted the sync-from-ra branch November 28, 2024 11:29
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (c1cfab2): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.0% [2.0%, 2.0%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary 0.1%, secondary 2.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
3.2% [3.2%, 3.2%] 1
Regressions ❌
(secondary)
2.7% [2.7%, 2.7%] 1
Improvements ✅
(primary)
-3.0% [-3.0%, -3.0%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.1% [-3.0%, 3.2%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 792.58s -> 793.251s (0.08%)
Artifact size: 335.88 MiB -> 335.84 MiB (-0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.