Structurally resolve before matching on type of projection

[compiler-errors]

Another missing structural resolve in closure upvar analysis. I think it's better to place the normalization here rather than trying to guarantee that all types returned by the expr use visitor are structurally normalized, which I don't think we do now. Thoughts?

r? lcnr

[lcnr]

Could we make all the types deeply normalized here, similar to what we try to do in writeback 🤔 I think I would prefer that long term, but rn I am not sure whether that's possible.

Maybe add a FIXME(-Znext-solver): Consider instead requiring the type to already be structurally/deeply normalized here, then r=me

[lcnr]

convinced this is the right place to normalize

@bors r+ rollup

[bors]

📌 Commit 48b2bbd has been approved by lcnr

It is now in the queue for this repository.

[Kobzol]

@rust-timer build 88f6bbe

[rust-timer]

Finished benchmarking commit (88f6bbe): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 1.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.8%	[2.9%, 4.7%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.3%	[-3.3%, -3.3%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.5%	[-3.3%, 4.7%]	3

Cycles

Results (primary -1.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.7%	[-2.1%, -1.5%]	4
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.7%	[-2.1%, -1.5%]	4

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 794.328s -> 794.674s (0.04%)
Artifact size: 335.88 MiB -> 335.89 MiB (0.00%)