Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove is_trivially_const_drop #133371

Merged
merged 1 commit into from
Nov 24, 2024
Merged

remove is_trivially_const_drop #133371

merged 1 commit into from
Nov 24, 2024

Conversation

RalfJung
Copy link
Member

I'm not sure this still brings any perf benefits, so let's benchmark this.

r? @compiler-errors

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 23, 2024
@rustbot
Copy link
Collaborator

rustbot commented Nov 23, 2024

Some changes occurred to the CTFE machinery

cc @rust-lang/wg-const-eval

@RalfJung
Copy link
Member Author

@bors try
@rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 23, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 23, 2024
@bors
Auto merge of rust-lang#133371 - RalfJung:is_trivially_const_drop, r=…
b40cffa 
…<try>

remove is_trivially_const_drop

I'm not sure this still brings any perf benefits, so let's benchmark this.

r? `@compiler-errors`
@bors
Copy link
Contributor

bors commented Nov 23, 2024

⌛ Trying commit 5645d66 with merge b40cffa...

@compiler-errors
Copy link
Member

if perf is neutral then r=me

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@RalfJung RalfJung force-pushed the is_trivially_const_drop branch from 5645d66 to bd00de7 Compare November 23, 2024 07:41
@rustbot
Copy link
Collaborator

rustbot commented Nov 23, 2024

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@RalfJung
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Nov 23, 2024

⌛ Trying commit bd00de7 with merge 5f8e705...

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 23, 2024
@bors
Auto merge of rust-lang#133371 - RalfJung:is_trivially_const_drop, r=…
5f8e705 
…<try>

remove is_trivially_const_drop

I'm not sure this still brings any perf benefits, so let's benchmark this.

r? `@compiler-errors`
@bors
Copy link
Contributor

bors commented Nov 23, 2024

☀️ Try build successful - checks-actions
Build commit: 5f8e705 (5f8e7058d31eaf1c73bf220322209f5bec6532b1)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (5f8e705): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 0.6%, secondary 1.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 3.0% [3.0%, 3.0%] 1
Regressions ❌
(secondary)		 1.2% [1.0%, 1.5%] 2
Improvements ✅
(primary)		 -1.8% [-1.8%, -1.8%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.6% [-1.8%, 3.0%] 2

Cycles

Results (secondary -2.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.3% [-2.3%, -2.3%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 795.253s -> 796.142s (0.11%)
Artifact size: 336.22 MiB -> 336.25 MiB (0.01%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 23, 2024
@RalfJung
Copy link
Member Author

RalfJung commented Nov 23, 2024 via email

@bors
Copy link
Contributor

bors commented Nov 23, 2024

📌 Commit bd00de7 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 23, 2024
@compiler-errors
Copy link
Member

@bors rollup

@matthiaskrgr matthiaskrgr mentioned this pull request Nov 24, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 24, 2024
@bors
Auto merge of rust-lang#133415 - matthiaskrgr:rollup-n1ivyd5, r=matth…
f5d1857 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#133300 (inject_panic_runtime(): Avoid double negation for 'any non rlib')
 - rust-lang#133301 (Add code example for `wrapping_neg` method for signed integers)
 - rust-lang#133371 (remove is_trivially_const_drop)
 - rust-lang#133389 (Stabilize `const_float_methods`)
 - rust-lang#133398 (rustdoc: do not call to_string, it's already impl Display)
 - rust-lang#133405 (tidy: Distinguish between two different meanings of "style file")

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5d1c992 into rust-lang:master Nov 24, 2024
7 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Nov 24, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 24, 2024
@rust-timer
Unrolled build for rust-lang#133371
05fb9f9 
Rollup merge of rust-lang#133371 - RalfJung:is_trivially_const_drop, r=compiler-errors

remove is_trivially_const_drop

I'm not sure this still brings any perf benefits, so let's benchmark this.

r? `@compiler-errors`
@RalfJung RalfJung deleted the is_trivially_const_drop branch November 26, 2024 22:29
flip1995 pushed a commit to flip1995/rust that referenced this pull request Nov 28, 2024
@matthiaskrgr
Rollup merge of rust-lang#133371 - RalfJung:is_trivially_const_drop, …
728826f 
…r=compiler-errors

remove is_trivially_const_drop

I'm not sure this still brings any perf benefits, so let's benchmark this.

r? `@compiler-errors`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.85.0
Development

Successfully merging this pull request may close these issues.
6 participants
@RalfJung @rustbot @rust-timer @bors @compiler-errors @rust-log-analyzer