Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark slice::copy_from_slice unstably const #131416

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Conversation

okaneco
Copy link
Contributor

@okaneco okaneco commented Oct 8, 2024

Tracking issue #131415

I used const_eval_select for runtime and const panic functions because const formatting isn't available yet.

@rustbot
Copy link
Collaborator

rustbot commented Oct 8, 2024

r? @Noratrieb

rustbot has assigned @Noratrieb.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 8, 2024
@RalfJung
Copy link
Member

r? libs-api

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Oct 11, 2024
@rustbot rustbot assigned m-ou-se and unassigned Noratrieb Oct 11, 2024
@alex-semenyuk alex-semenyuk added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 27, 2024
@alex-semenyuk
Copy link
Member

alex-semenyuk commented Nov 27, 2024

@okaneco
From wg-triage. Could you please take a look comments?

@RalfJung
Copy link
Member

RalfJung commented Dec 1, 2024

This is unstable (i.e., we can take it back if needed) and should be uncontroversial, so let me just

@bors r+

@bors
Copy link
Contributor

bors commented Dec 1, 2024

📌 Commit 7f011a8 has been approved by RalfJung

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 1, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 2, 2024
Rollup of 5 pull requests

Successful merges:

 - rust-lang#131416 (Mark `slice::copy_from_slice` unstably const)
 - rust-lang#131784 (Stabilize unsigned and float variants of `num_midpoint` feature)
 - rust-lang#133446 (coverage: Use a query to identify which counter/expression IDs are used)
 - rust-lang#133711 (add isatty doc alias for `is_terminal`)
 - rust-lang#133712 (rust_analyzer_settings: force use of 'nightly' toolchain)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit cb67512 into rust-lang:master Dec 2, 2024
6 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Dec 2, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 2, 2024
Rollup merge of rust-lang#131416 - okaneco:const_copy, r=RalfJung

Mark `slice::copy_from_slice` unstably const

Tracking issue rust-lang#131415

I used `const_eval_select` for runtime and const panic functions because const formatting isn't available yet.
@okaneco okaneco deleted the const_copy branch December 2, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants