Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: Remove usage of allow(unused) attribute on no_run merged doctests #131096

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

GuillaumeGomez
Copy link
Member

Fixes #130681.

It fixes the behaviour difference with the current doctests.

r? @notriddle

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Oct 1, 2024
@traviscross
Copy link
Contributor

@rust-lang/rustdoc: Note that this item is related to the upcoming edition. If this could be addressed, it will help with the testing of the edition.

@GuillaumeGomez
Copy link
Member Author

Completely forgot about it.

Ping @notriddle

@notriddle
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Oct 29, 2024

📌 Commit b073ddc has been approved by notriddle

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 29, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 29, 2024
…riddle

rustdoc: Remove usage of `allow(unused)` attribute on `no_run` merged doctests

Fixes [rust-lang#130681](rust-lang#130681).

It fixes the behaviour difference with the current doctests.

r? `@notriddle`
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 29, 2024
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#129394 (Don't lint `irrefutable_let_patterns` on leading patterns if `else if` let-chains)
 - rust-lang#131096 (rustdoc: Remove usage of `allow(unused)` attribute on `no_run` merged doctests)
 - rust-lang#132322 (powerpc64-ibm-aix: update maintainters)
 - rust-lang#132327 (Point to Fuchsia team in platform support docs)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 30, 2024
Rollup of 6 pull requests

Successful merges:

 - rust-lang#130098 (Reject generic self types.)
 - rust-lang#131096 (rustdoc: Remove usage of `allow(unused)` attribute on `no_run` merged doctests)
 - rust-lang#132315 (compiletest: improve robustness of LLVM version handling)
 - rust-lang#132346 (Some graphviz tweaks)
 - rust-lang#132359 (Fix AIX libc call char type from i8 to u8)
 - rust-lang#132360 (Un-vacation myself)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a864e30 into rust-lang:master Oct 30, 2024
6 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Oct 30, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 30, 2024
Rollup merge of rust-lang#131096 - GuillaumeGomez:rm-no_unused, r=notriddle

rustdoc: Remove usage of `allow(unused)` attribute on `no_run` merged doctests

Fixes [rust-lang#130681](rust-lang#130681).

It fixes the behaviour difference with the current doctests.

r? ``@notriddle``
@GuillaumeGomez GuillaumeGomez deleted the rm-no_unused branch October 30, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

merged doctests: implicit unused overrides explicit attributes with no_run
5 participants