-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #130859
base: master
Are you sure you want to change the base?
Update README.md #130859
Conversation
fix grammatical issues
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
Co-authored-by: Jeff Parsons <jeff@parsons.io>
@@ -41,7 +41,7 @@ Read ["Installation"] from [The Book]. | |||
|
|||
## Installing from Source | |||
|
|||
If you really want to install from source (though this is not recommended), see |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is intended, as installing from source is not encouraged and not what the average user is supposed to do
Co-authored-by: Mark Rousskov <mark.simulacrum@gmail.com>
Is this good to merge? @jeffparsons / @Mark-Simulacrum / @Noratrieb |
#130859 (comment) still seems unresolved? |
@AzharMithani
|
Thanks, updated |
@AzharMithani by resolving it they meant you need to undo that change because the »really« was there for emphasis. |
Ah, I see, however, that would be grammatically incorrect. For example, in the above statement, I could have said "that really would be grammatically incorrect" but the meaning doesn't change 👍 |
☔ The latest upstream changes (presumably #134096) made this pull request unmergeable. Please resolve the merge conflicts. |
fixed grammatical issues