Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #130859

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update README.md #130859

wants to merge 3 commits into from

Conversation

AzharMithani
Copy link

fixed grammatical issues

fix grammatical issues
@rustbot
Copy link
Collaborator

rustbot commented Sep 25, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 25, 2024
README.md Outdated Show resolved Hide resolved
Co-authored-by: Jeff Parsons <jeff@parsons.io>
@@ -41,7 +41,7 @@ Read ["Installation"] from [The Book].

## Installing from Source

If you really want to install from source (though this is not recommended), see
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is intended, as installing from source is not encouraged and not what the average user is supposed to do

README.md Outdated Show resolved Hide resolved
Co-authored-by: Mark Rousskov <mark.simulacrum@gmail.com>
@AzharMithani
Copy link
Author

Is this good to merge? @jeffparsons / @Mark-Simulacrum / @Noratrieb

@Mark-Simulacrum
Copy link
Member

#130859 (comment) still seems unresolved?

@alex-semenyuk alex-semenyuk added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 19, 2024
@alex-semenyuk
Copy link
Member

alex-semenyuk commented Nov 19, 2024

@AzharMithani
From wg-triage. Could you please take a look?

#130859 (comment) still seems unresolved?

@AzharMithani
Copy link
Author

@AzharMithani From wg-triage. Could you please take a look?

#130859 (comment) still seems unresolved?

Thanks, updated

@Dylan-DPC
Copy link
Member

@AzharMithani by resolving it they meant you need to undo that change because the »really« was there for emphasis.

@AzharMithani
Copy link
Author

@AzharMithani by resolving it they meant you need to undo that change because the »really« was there for emphasis.

Ah, I see, however, that would be grammatically incorrect.

For example, in the above statement, I could have said "that really would be grammatically incorrect" but the meaning doesn't change 👍

@bors
Copy link
Contributor

bors commented Dec 10, 2024

☔ The latest upstream changes (presumably #134096) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants