compiletest: clarify COMPILETEST_NEEDS_ALL_LLVM_COMPONENTS error #125710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @wesleywiser rustbot has assigned @wesleywiser. Use |
|
Some changes occurred in src/tools/compiletest cc @jieyouxu |
also improve wording for an ignore reason
3c61b9b to
4ce7e09
Compare
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (434999e): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 670.547s -> 672.444s (0.28%) |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 17, 2024
Revert "tidy: validate LLVM component names in tests" This reverts rust-lang#125472. This has already caused a [bit](rust-lang#125702) of [trouble](rust-lang#125710), and I was mistaken about the original motivation--incorrect component names [_will_](rust-lang#125702 (comment)) be detected by a full CI run. I no longer think it pulls its weight. r? `@workingjubilee`
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Nov 18, 2024
Revert "tidy: validate LLVM component names in tests" This reverts #125472. This has already caused a [bit](rust-lang/rust#125702) of [trouble](rust-lang/rust#125710), and I was mistaken about the original motivation--incorrect component names [_will_](rust-lang/rust#125702 (comment)) be detected by a full CI run. I no longer think it pulls its weight. r? `@workingjubilee`
lnicola
pushed a commit
to lnicola/rust-analyzer
that referenced
this pull request
Nov 28, 2024
Revert "tidy: validate LLVM component names in tests" This reverts #125472. This has already caused a [bit](rust-lang/rust#125702) of [trouble](rust-lang/rust#125710), and I was mistaken about the original motivation--incorrect component names [_will_](rust-lang/rust#125702 (comment)) be detected by a full CI run. I no longer think it pulls its weight. r? `@workingjubilee`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPILETEST_NEEDS_ALL_LLVM_COMPONENTS is a confusing name because elsewhere "needs" means "ignore when requirement not met", but here it means "fail when requirement not met".