Rollup of 5 pull requests #125079
Closed
Rollup of 5 pull requests #125079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifying an environment variable would make the function unsafe to call.
…e line In particular, lifetime-generic associated types often have a `where Self: 'a` bound, which we can format on the same line.
Show an example that has bounds.
Suggested-by: Caleb Cartwright <calebcartwright@users.noreply.github.com>
…-clause-same-line, r=compiler-errors style-guide: Format single associated type `where` clauses on the same line In particular, lifetime-generic associated types often have a `where Self: 'a` bound, which we can format on the same line.
…ert-label, r=apiraino [meta] Clarify prioritization alert Apparently, there used to exist the label <kbd>I-nominated</kbd> judging from this entry: https://github.com/rust-lang/rust/blob/8847bda592d940ae1f34d87d8cacdc09a9f787fa/triagebot.toml#L393 Since it was replaced with individual team labels, I think it makes sense to update the prioritization alert. Of course, it's not super important since the members of WG-prioritization already know that. This is just cleanup. r? apiraino or wg-prioritization
…er-errors
elaborate obligations in coherence
The following test currently does not pass coherence:
```rust
trait Super {}
trait Sub<T>: Super {}
trait Overlap<T> {}
impl<T, U: Sub<T>> Overlap<T> for U {}
impl<T> Overlap<T> for () {}
fn main() {}
```
We check whether `(): Sub<?t>` holds. This stalls with ambiguity as downstream crates may add an impl for `(): Sub<Local>`. However, its super trait bound `(): Super` cannot be implemented downstream, so this one is known not to hold.
By elaborating the bounds in the implicit negative overlap check, this now compiles. This is necessary to prevent breakage from enabling `-Znext-solver=coherence` (rust-lang#121848), see tests/ui/coherence/super-traits/super-trait-knowable-2.rs for more details.
r? `@compiler-errors`
Use a proper probe for shadowing impl r? lcnr
…lwoerister Don't call `env::set_var` in `rustc_driver::install_ice_hook` Modifying an environment variable would make the function unsafe to call.
|
@bors r+ rollup=never p=5 |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
whereclauses on the same line #119515 (style-guide: Format single associated typewhereclauses on the same line)env::set_varinrustc_driver::install_ice_hook#125063 (Don't callenv::set_varinrustc_driver::install_ice_hook)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup