Move extra::c_vec to collections. #12469
Conversation
cc #8784 Signed-off-by: OGINO Masanori <masanori.ogino@gmail.com>
|
This seems a little like something that would be better suited to a "libffi" or something, since it's not really a datastructure itself. I don't really know. |
|
Then I think |
|
Libffi sounds promising, though I don't know offhand what else goes there. I do think libc deserves its own crate, so maybe c_vec goes there (I'm not sure what c_vec is)? Let's try that. This then raises questions about c_str. |
|
cc #12514 for a similar suggestion.
|
|
It seems that there is a consensus that Feel free to reopen this if I overlooked something. |
chore: fix some typos Thank you for making Clippy better! We're collecting our changelog from pull request descriptions. If your PR only includes internal changes, you can just write `changelog: none`. Otherwise, please write a short comment explaining your change. It's also helpful for us that the lint name is put within backticks (`` ` ` ``), and then encapsulated by square brackets (`[]`), for example: ``` changelog: [`lint_name`]: your change ``` If your PR fixes an issue, you can add `fixes #issue_number` into this PR description. This way the issue will be automatically closed when your PR is merged. If you added a new lint, here's a checklist for things that will be checked during review or continuous integration. - \[x] Followed [lint naming conventions][lint_naming] - \[ ] Added passing UI tests (including committed `.stderr` file) - \[ ] `cargo test` passes locally - \[ ] Executed `cargo dev update_lints` - \[ ] Added lint documentation - \[x] Run `cargo dev fmt` [lint_naming]: https://rust-lang.github.io/rfcs/0344-conventions-galore.html#lints Note that you can skip the above if you are just opening a WIP PR in order to get feedback. Delete this line and everything above before opening your PR. --- *Please write a short comment explaining your change (or "none" for internal only changes)* changelog:
cc #8784