Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Triagebot: Rename macos ping group to apple #124146

Merged
merged 3 commits into from
May 6, 2024
Merged

Triagebot: Rename macos ping group to apple #124146

merged 3 commits into from
May 6, 2024

Conversation

madsmtm
Copy link
Contributor

@madsmtm madsmtm commented Apr 19, 2024

Expand the scope of the macOS ping group to all Apple targets.

Blocked on rust-lang/team#1436 (rename in team repo)
Blocked on rust-lang/rustc-dev-guide#1964 (referenced documentation link)

@rustbot label O-macos O-ios O-tvos O-watchos O-visionos

@rustbot
Copy link
Collaborator

rustbot commented Apr 19, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 19, 2024
@rustbot
Copy link
Collaborator

rustbot commented Apr 19, 2024

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

@rustbot rustbot added O-ios Operating system: iOS O-macos Operating system: macOS O-tvos Operating system: tvOS (including simulator) O-visionos Apple visionOS O-watchos Operating System: watchOS labels Apr 19, 2024
@madsmtm madsmtm mentioned this pull request Apr 19, 2024
Merged
@Mark-Simulacrum Mark-Simulacrum added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 20, 2024
madsmtm
madsmtm commented Apr 21, 2024
View reviewed changes
triagebot.toml Outdated Show resolved Hide resolved
@pthariensflame pthariensflame mentioned this pull request Apr 21, 2024
Closed
@madsmtm madsmtm mentioned this pull request May 4, 2024
Merged
@dtolnay dtolnay mentioned this pull request May 5, 2024
Merged
@dtolnay dtolnay assigned dtolnay and unassigned Mark-Simulacrum May 5, 2024
dtolnay
dtolnay approved these changes May 5, 2024
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dtolnay
Copy link
Member

dtolnay commented May 5, 2024

@bors r+

To re-approve if you end up changing the label:
@bors delegate+

@bors
Copy link
Contributor

bors commented May 5, 2024

📌 Commit e64cbc4 has been approved by dtolnay

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels May 5, 2024
@bors
Copy link
Contributor

bors commented May 5, 2024

✌️ @madsmtm, you can now approve this pull request!

If @dtolnay told you to "r=me" after making some further change, please make that change, then do @bors r=@dtolnay

@madsmtm
Copy link
Contributor Author

madsmtm commented May 5, 2024

@bors r=dtolnay

@bors
Copy link
Contributor

bors commented May 5, 2024

📌 Commit c50ea6c has been approved by dtolnay

It is now in the queue for this repository.

bors added a commit to rust-lang-ci/rust that referenced this pull request May 5, 2024
@bors
Auto merge of rust-lang#124146 - madsmtm:apple-triage, r=dtolnay
474cd23 
Triagebot: Rename `macos` ping group to `apple`

Expand the scope of the macOS ping group to all Apple targets.

Blocked on rust-lang/team#1436 (rename in `team` repo)
Blocked on rust-lang/rustc-dev-guide#1964 (referenced documentation link)

`@rustbot` label O-macos O-ios O-tvos O-watchos O-visionos
@bors
Copy link
Contributor

bors commented May 5, 2024

⌛ Testing commit c50ea6c with merge 474cd23...

@madsmtm
Copy link
Contributor Author

madsmtm commented May 5, 2024

Oops, accidentally changed the wrong place in triagebot.toml, unsure if that broke bors, but let's try again:
@bors r=dtolnay

@bors
Copy link
Contributor

bors commented May 5, 2024

📌 Commit dc153f8 has been approved by dtolnay

It is now in the queue for this repository.

fmease added a commit to fmease/rust that referenced this pull request May 5, 2024
@fmease
Rollup merge of rust-lang#124146 - madsmtm:apple-triage, r=dtolnay
6fc3ff3 
Triagebot: Rename `macos` ping group to `apple`

Expand the scope of the macOS ping group to all Apple targets.

Blocked on rust-lang/team#1436 (rename in `team` repo)
Blocked on rust-lang/rustc-dev-guide#1964 (referenced documentation link)

`@rustbot` label O-macos O-ios O-tvos O-watchos O-visionos
@fmease fmease mentioned this pull request May 5, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request May 5, 2024
@bors
Auto merge of rust-lang#124769 - fmease:rollup-gwdj5yz, r=fmease
be0e608 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#124146 (Triagebot: Rename `macos` ping group to `apple`)
 - rust-lang#124742 (Add `rustfmt` cfg to well known cfgs list)
 - rust-lang#124745 (Implement lldb formattter for "clang encoded" enums (LLDB 18.1+) (v2))
 - rust-lang#124747 (Support Result<T, E> across FFI when niche optimization can be used (v2))
 - rust-lang#124765 ([rustdoc] Fix bad color for setting cog in ayu theme)
 - rust-lang#124768 ([resubmission] Meta: Enable the brand new triagebot transfer command)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
Copy link
Contributor

bors commented May 5, 2024

⌛ Testing commit dc153f8 with merge 3170bd9...

@bors
Copy link
Contributor

bors commented May 6, 2024

☀️ Test successful - checks-actions
Approved by: dtolnay
Pushing 3170bd9 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 6, 2024
@bors bors merged commit 3170bd9 into rust-lang:master May 6, 2024
7 checks passed
@rustbot rustbot added this to the 1.80.0 milestone May 6, 2024
@madsmtm madsmtm deleted the apple-triage branch May 6, 2024 00:43
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (3170bd9): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 2.3% [2.2%, 2.3%] 3
Regressions ❌
(secondary)		 2.1% [2.1%, 2.1%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -5.0% [-5.0%, -5.0%] 1
All ❌✅ (primary) 2.3% [2.2%, 2.3%] 3

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 676.55s -> 675.885s (-0.10%)
Artifact size: 315.72 MiB -> 315.88 MiB (0.05%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtwco davidtwco davidtwco left review comments

@dtolnay dtolnay dtolnay approved these changes

Assignees

@dtolnay dtolnay

Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself merged-by-bors This PR was explicitly merged by bors. O-ios Operating system: iOS O-macos Operating system: macOS O-tvos Operating system: tvOS (including simulator) O-visionos Apple visionOS O-watchos Operating System: watchOS S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.80.0
Development

Successfully merging this pull request may close these issues.
7 participants
@madsmtm @rustbot @dtolnay @bors @rust-timer @davidtwco @Mark-Simulacrum