Remove default_hidden_visibility: false from wasm targets
#124036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To the best of my ability I believe that this is no longer necessary. I don't fully recall why this was first added but I believe it had to do with symbols all being exported by default and this was required to undo that. Regardless nowadays the default output of rustc seems suitable so it seems best to keep wasm in line with other targets.
|
These commits modify compiler targets. |
|
The removal looks reasonable to me. Do we want to add a test here to check that wasm symbol visibilities generated by the current default rustc output don't regress in the future? As in, we have a default hidden visibilities codegen test but that seems to be |
|
I'd be personally ok skipping a test here since afaik this was just a quirk of the wasm runtime at the time which is no longer necessary. Everything's a bit different on wasm in terms of objects and such so I'd fear that a wasm-specific test might just add boilerplate to update rather than prevent a regression |
|
Makes sense 👍 |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 17, 2024
…llaumeGomez Rollup of 7 pull requests Successful merges: - rust-lang#123673 (Don't ICE for kind mismatches during error rendering) - rust-lang#123675 (Taint const qualifs if a static is referenced that didn't pass wfcheck) - rust-lang#123975 (Port the 2 `rust-lld` run-make tests to `rmake`) - rust-lang#124000 (Use `/* value */` as a placeholder) - rust-lang#124013 (Box::into_raw: make Miri understand that this is a box-to-raw cast) - rust-lang#124027 (Prefer identity equality over equating types during coercion.) - rust-lang#124036 (Remove `default_hidden_visibility: false` from wasm targets) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 17, 2024
Rollup merge of rust-lang#124036 - alexcrichton:wasm-use-default-visbility, r=jieyouxu Remove `default_hidden_visibility: false` from wasm targets To the best of my ability I believe that this is no longer necessary. I don't fully recall why this was first added but I believe it had to do with symbols all being exported by default and this was required to undo that. Regardless nowadays the default output of rustc seems suitable so it seems best to keep wasm in line with other targets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To the best of my ability I believe that this is no longer necessary. I don't fully recall why this was first added but I believe it had to do with symbols all being exported by default and this was required to undo that. Regardless nowadays the default output of rustc seems suitable so it seems best to keep wasm in line with other targets.