rustc_ast: Update P<T> docs to reflect mutable status.
#123393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Noratrieb
reviewed
Apr 3, 2024
| //! implementation changes (using a special thread-local heap, for example). | ||
| //! Moreover, a switch to, e.g., `P<'a, T>` would be easy and mostly automated. | ||
| //! * **Maintainability**: `P<T>` provides an interface, which can remain fully | ||
| //! functional even if the implementation changes (using a special thread-local |
There was a problem hiding this comment.
top ten things that didn't happen
Noratrieb
approved these changes
Apr 3, 2024
`P<T>` has implemented `DerefMut` since rust-lang#54277. While this was lamented at the time [1], rustc now relies on it extensively via the many implementors of MutVisitor [2]. Updates the docs to reflect that `P<T>` is fundamentally mutable, and a few other cleanups to make them nicer to browse. [1]: rust-lang#54277 (comment) [2]: https://doc.rust-lang.org/1.77.1/nightly-rustc/rustc_ast/mut_visit/trait.MutVisitor.html#implementors
14aaf02 to
5075931
Compare
|
@bors r+ rollup |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 3, 2024
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#123209 (Add section to sanitizer doc for `-Zexternal-clangrt`) - rust-lang#123342 (x.py test: remove no-op --skip flag) - rust-lang#123382 (Assert `FnDef` kind) - rust-lang#123386 (Set `CARGO` instead of `PATH` for Rust Clippy) - rust-lang#123393 (rustc_ast: Update `P<T>` docs to reflect mutable status.) - rust-lang#123394 (Postfix match fixes) - rust-lang#123412 (Output URLs of CI artifacts to GitHub summary) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 3, 2024
Rollup merge of rust-lang#123393 - aDotInTheVoid:ast-p-docs, r=Nilstrieb rustc_ast: Update `P<T>` docs to reflect mutable status. `P<T>` has implemented `DerefMut` since rust-lang#54277. While this was lamented at the time [1], rustc now relies on it extensively via the many implementors of MutVisitor [2]. Updates the docs to reflect that `P<T>` is fundamentally mutable, and a few other cleanups to make them nicer to browse. [1]: rust-lang#54277 (comment) [2]: https://doc.rust-lang.org/1.77.1/nightly-rustc/rustc_ast/mut_visit/trait.MutVisitor.html#implementors r? `@Nilstrieb`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
P<T>has implementedDerefMutsince #54277. While this was lamented at the time 1, rustc now relies on it extensively via the many implementors of MutVisitor 2.Updates the docs to reflect that
P<T>is fundamentally mutable, and a few other cleanups to make them nicer to browse.r? @Nilstrieb