Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore paths from expansion in unused_qualifications #122545

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Ignore paths from expansion in unused_qualifications #122545

merged 1 commit into from
Mar 21, 2024
+5 −1

Conversation

Alexendoo
Copy link
Member

If any of the path segments are from an expansion the lint is skipped currently, but a path from an expansion where all of the segments are passed in would not be. Doesn't seem that likely to occur but it could happen

@rustbot
Copy link
Collaborator

rustbot commented Mar 15, 2024

r? @michaelwoerister

rustbot has assigned @michaelwoerister.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 15, 2024
@Kobzol Kobzol mentioned this pull request Mar 15, 2024
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 15, 2024
@matthiaskrgr
Rollup merge of rust-lang#122563 - Kobzol:ci-pr-caching, r=Mark-Simul…
2ab4ce1 
…acrum

CI: cache PR CI Docker builds

An attempt to restore Docker caching for PR CI workflows that share the Docker image with an auto/try workflow.

This was broken by my previous [PR](rust-lang#119290) that changed how we cache the Docker builds.

[Before](rust-lang#122545):
![image](https://github.com/rust-lang/rust/assets/4539057/05e0d347-af64-4e85-bc99-0e4ac07192ec)

After:
![image](https://github.com/rust-lang/rust/assets/4539057/2f657d60-b242-45eb-ac61-d8f71787edda)

r? `@ghost`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 15, 2024
@matthiaskrgr
Rollup merge of rust-lang#122563 - Kobzol:ci-pr-caching, r=Mark-Simul…
948e031 
…acrum

CI: cache PR CI Docker builds

An attempt to restore Docker caching for PR CI workflows that share the Docker image with an auto/try workflow.

This was broken by my previous [PR](rust-lang#119290) that changed how we cache the Docker builds.

[Before](rust-lang#122545):
![image](https://github.com/rust-lang/rust/assets/4539057/05e0d347-af64-4e85-bc99-0e4ac07192ec)

After:
![image](https://github.com/rust-lang/rust/assets/4539057/2f657d60-b242-45eb-ac61-d8f71787edda)

r? ``@ghost``
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 15, 2024
@rust-timer
Unrolled build for rust-lang#122563
3f5868e 
Rollup merge of rust-lang#122563 - Kobzol:ci-pr-caching, r=Mark-Simulacrum

CI: cache PR CI Docker builds

An attempt to restore Docker caching for PR CI workflows that share the Docker image with an auto/try workflow.

This was broken by my previous [PR](rust-lang#119290) that changed how we cache the Docker builds.

[Before](rust-lang#122545):
![image](https://github.com/rust-lang/rust/assets/4539057/05e0d347-af64-4e85-bc99-0e4ac07192ec)

After:
![image](https://github.com/rust-lang/rust/assets/4539057/2f657d60-b242-45eb-ac61-d8f71787edda)

r? ``@ghost``
@bors

This comment was marked as resolved.

Sign in to view
@michaelwoerister
Copy link
Member

Thanks for the PR, @Alexendoo! This looks sensible to me, but r? @petrochenkov for double checking.

@petrochenkov
Copy link
Contributor

I don't think it's possible to construct a path with such span, except by AST-based built-in macros.
But I don't see any harm here either, except maybe a tiny performance difference.
r=me after rebase.
@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 20, 2024
@Alexendoo Alexendoo force-pushed the unused-qualifications branch from 8ad6af7 to a845246 Compare March 20, 2024 16:30
@petrochenkov
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 20, 2024

📌 Commit a845246 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 20, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 20, 2024
@matthiaskrgr
Rollup merge of rust-lang#122545 - Alexendoo:unused-qualifications, r…
f343870 
…=petrochenkov

Ignore paths from expansion in `unused_qualifications`

If any of the path segments are from an expansion the lint is skipped currently, but a path from an expansion where all of the segments are passed in would not be. Doesn't seem that likely to occur but it could happen
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 20, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 20, 2024
@bors
Auto merge of rust-lang#122794 - matthiaskrgr:rollup-tql9mpa, r=matth…
bb319dd 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#122545 (Ignore paths from expansion in `unused_qualifications`)
 - rust-lang#122644 (pattern analysis: add a custom test harness)
 - rust-lang#122696 (Add bare metal riscv32 target.)
 - rust-lang#122729 (Relax SeqCst ordering in standard library.)
 - rust-lang#122740 (use more accurate terminology)
 - rust-lang#122749 (make `type_flags(ReError) & HAS_ERROR`)
 - rust-lang#122764 (coverage: Remove incorrect assertions from counter allocation)
 - rust-lang#122765 (Add `usize::MAX` arg tests for Vec)
 - rust-lang#122776 (Rename `hir::Let` into `hir::LetExpr`)
 - rust-lang#122786 (compiletest: Introduce `remove_and_create_dir_all()` helper)

r? `@ghost`
`@rustbot` modify labels: rollup
@jhpratt jhpratt mentioned this pull request Mar 21, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 21, 2024
@bors
Auto merge of rust-lang#122803 - jhpratt:rollup-nmgs79k, r=jhpratt
6a6cd65 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#122545 (Ignore paths from expansion in `unused_qualifications`)
 - rust-lang#122729 (Relax SeqCst ordering in standard library.)
 - rust-lang#122740 (use more accurate terminology)
 - rust-lang#122749 (make `type_flags(ReError) & HAS_ERROR`)
 - rust-lang#122764 (coverage: Remove incorrect assertions from counter allocation)
 - rust-lang#122765 (Add `usize::MAX` arg tests for Vec)
 - rust-lang#122776 (Rename `hir::Let` into `hir::LetExpr`)
 - rust-lang#122786 (compiletest: Introduce `remove_and_create_dir_all()` helper)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 31adfd7 into rust-lang:master Mar 21, 2024
11 checks passed
@rustbot rustbot added this to the 1.79.0 milestone Mar 21, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 21, 2024
@rust-timer
Unrolled build for rust-lang#122545
f9b0e58 
Rollup merge of rust-lang#122545 - Alexendoo:unused-qualifications, r=petrochenkov

Ignore paths from expansion in `unused_qualifications`

If any of the path segments are from an expansion the lint is skipped currently, but a path from an expansion where all of the segments are passed in would not be. Doesn't seem that likely to occur but it could happen
@Alexendoo Alexendoo deleted the unused-qualifications branch May 10, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.79.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Alexendoo @rustbot @bors @michaelwoerister @petrochenkov